Bug 12214 - firewire-ohci: AR handler incorrect for 4kB sized packets
Summary: firewire-ohci: AR handler incorrect for 4kB sized packets
Status: CLOSED PATCH_ALREADY_AVAILABLE
Alias: None
Product: Drivers
Classification: Unclassified
Component: IEEE1394 (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: drivers_ieee1394
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-13 05:15 UTC by Stefan Richter
Modified: 2012-05-30 12:29 UTC (History)
1 user (show)

See Also:
Kernel Version: all
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Stefan Richter 2008-12-13 05:15:30 UTC 
When I looked at it in March, the AR handler did not handle large packets entirely correctly.  I didn't verify again right now but the problem is presumably still there.
http://marc.info/?l=linux1394-devel&m=120660462821255
Comment 1 Stefan Richter 2010-10-25 13:47:02 UTC 
Candidate fixes by Clemens Ladisch:
http://thread.gmane.org/gmane.linux.kernel.firewire.devel/14502
Comment 2 Stefan Richter 2010-10-31 12:39:15 UTC 
The patches from comment 1 work for me.
Comment 3 Stefan Richter 2010-11-06 08:31:08 UTC 
Fixes merged into mainline, to appear in 2.6.37-rc2, also submitted for inclusion into currently active stable series.
Comment 4 Stefan Richter 2010-11-08 14:43:57 UTC 
Wait, what was I thinking?  While there were corrections regarding reassembly of packets that cross page boundaries, 4kB sized packets are still not handled.
Comment 5 Alan 2012-05-30 11:33:13 UTC 
Status ?
Comment 6 Stefan Richter 2012-05-30 12:28:57 UTC 
This was fixed in 2.6.38 by commit 7a39d8b82165462729d09066bddb395a19025acd.
http://git.kernel.org/linus/7a39d8b82165462729d09066bddb395a19025acd
Note You need to log in before you can comment on or make changes to this bug.