Bug 117561 - pciehp error on resume
Summary: pciehp error on resume
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: PCI (show other bugs)
Hardware: All Linux
: P1 low
Assignee: drivers_pci@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-03 15:07 UTC by Bruno Pagani
Modified: 2016-06-08 12:21 UTC (History)
2 users (show)

See Also:
Kernel Version: 4.6.1-ARCH
Subsystem:
Regression: No
Bisected commit-id:


Attachments
diff in dmesg after suspend+resume (4.90 KB, text/x-log)
2016-05-03 15:07 UTC, Bruno Pagani
Details
lspci -vvv -s 00:1c.0 (3.05 KB, text/plain)
2016-05-03 16:48 UTC, Bruno Pagani
Details
Full dmesg (boot+screenclose/open+suspend/resume) (65.67 KB, text/x-log)
2016-05-03 17:23 UTC, Bruno Pagani
Details
lspci -vvv (28.60 KB, text/x-log)
2016-05-03 17:23 UTC, Bruno Pagani
Details

Description Bruno Pagani 2016-05-03 15:07:14 UTC
Created attachment 215111 [details]
diff in dmesg after suspend+resume

Hi,

Every time I suspend and then resume, two lines appear in red in dmesg, so I thought it was worth reporting:
pciehp 0000:00:1c.0:pcie04: link training error: status 0x1001
pciehp 0000:00:1c.0:pcie04: Failed to check link status

It seems harmless (i.e. I have not seen any issue that could be linked), but you will never know.

I’ve attached the full output added to dmesg when suspending+resuming.

Per https://bugzilla.kernel.org/show_bug.cgi?id=102841#c14, another user with same hardware is having the same error messages.
Comment 1 Bjorn Helgaas 2016-05-03 16:22:48 UTC
Thanks, Bruno.  Can you also attach the complete dmesg log (not just the part added after suspend/resume) and a complete "lspci -vv" output?

Do you know what slot this corresponds to?  The dmesg from bug #102841 shows this:

  pci 0000:00:1c.0: PCI bridge to [bus 04]
  pciehp 0000:00:1c.0:pcie04: Slot #0 AttnBtn- PwrCtrl- MRL- AttnInd- PwrInd- HotPlug+ Surprise+ Interlock- NoCompl+ LLActRep+

which looks like an ExpressCard or similar slot, but I don't see anything like that on the Dell XPS 15 9530, and I don't see any devices on bus 04.  Did you add or remove any devices while suspended?  I assume not, since it happens every time you suspend/resume, unless there's a dock or something involved.
Comment 2 Bruno Pagani 2016-05-03 16:48:52 UTC
Created attachment 215131 [details]
lspci -vvv -s 00:1c.0

Sorry, I indeed forgot to add the lspci output. It’s now attached.

No, I didn’t add or remove any devices while suspended (except for the power plug obviously).
Comment 3 Bruno Pagani 2016-05-03 16:54:31 UTC
Plus all lines from dmesg:
[    0.363084] pci 0000:00:1c.0: [8086:8c10] type 01 class 0x060400
[    0.363139] pci 0000:00:1c.0: PME# supported from D0 D3hot D3cold
[    0.363194] pci 0000:00:1c.0: System wakeup disabled by ACPI
[    0.364411] pci 0000:00:1c.0: PCI bridge to [bus 04]
[    0.532841] pci 0000:00:1c.0: bridge window [io  0x1000-0x0fff] to [bus 04] add_size 1000
[    0.532843] pci 0000:00:1c.0: bridge window [mem 0x00100000-0x000fffff 64bit pref] to [bus 04] add_size 200000 add_align 100000
[    0.532845] pci 0000:00:1c.0: bridge window [mem 0x00100000-0x000fffff] to [bus 04] add_size 200000 add_align 100000
[    0.532863] pci 0000:00:1c.0: res[14]=[mem 0x00100000-0x000fffff] res_to_dev_res add_size 200000 min_align 100000
[    0.532864] pci 0000:00:1c.0: res[14]=[mem 0x00100000-0x002fffff] res_to_dev_res add_size 200000 min_align 100000
[    0.532866] pci 0000:00:1c.0: res[15]=[mem 0x00100000-0x000fffff 64bit pref] res_to_dev_res add_size 200000 min_align 100000
[    0.532868] pci 0000:00:1c.0: res[15]=[mem 0x00100000-0x002fffff 64bit pref] res_to_dev_res add_size 200000 min_align 100000
[    0.532869] pci 0000:00:1c.0: res[13]=[io  0x1000-0x0fff] res_to_dev_res add_size 1000 min_align 1000
[    0.532871] pci 0000:00:1c.0: res[13]=[io  0x1000-0x1fff] res_to_dev_res add_size 1000 min_align 1000
[    0.532877] pci 0000:00:1c.0: BAR 14: assigned [mem 0xcf200000-0xcf3fffff]
[    0.532884] pci 0000:00:1c.0: BAR 15: assigned [mem 0xcf400000-0xcf5fffff 64bit pref]
[    0.532886] pci 0000:00:1c.0: BAR 13: assigned [io  0x2000-0x2fff]
[    0.532901] pci 0000:00:1c.0: PCI bridge to [bus 04]
[    0.532904] pci 0000:00:1c.0:   bridge window [io  0x2000-0x2fff]
[    0.532909] pci 0000:00:1c.0:   bridge window [mem 0xcf200000-0xcf3fffff]
[    0.532913] pci 0000:00:1c.0:   bridge window [mem 0xcf400000-0xcf5fffff 64bit pref]
[    0.562115] pcieport 0000:00:1c.0: Signaling PME through PCIe PME interrupt
[    0.562119] pcie_pme 0000:00:1c.0:pcie01: service driver pcie_pme loaded
[    0.562182] pciehp 0000:00:1c.0:pcie04: Slot #0 AttnBtn- PwrCtrl- MRL- AttnInd- PwrInd- HotPlug+ Surprise+ Interlock- NoCompl+ LLActRep+
[    0.562212] pciehp 0000:00:1c.0:pcie04: service driver pciehp loaded
Comment 4 Bjorn Helgaas 2016-05-03 17:05:58 UTC
Can you attach the *complete* dmesg log and *complete* "lspci -vv" output for the entire system, please?  I'm trying to figure out what (if anything) is connected below the 00:1c.0 port.  Anything connected there should be on bus 04.

If I'm reading the code correctly, we should have seen the slot Presence Detect State bit set if we got this far.  That indicates that we think there's a device there.  I suspect there actually is not a device there, but we should make sure before going too much further.

  pciehp_enable_slot
    pciehp_get_adapter_status(p_slot, &getstatus)
    if (!getstatus)
      return
    board_added
      pciehp_check_link_status
        pcie_wait_link_active
        pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status)
        ctrl_err(ctrl, "link training error: status 0x1001"
          0x1000 Slot Clock Configuration
          0x0001 Current Link Speed 2.5 GT/s
Comment 5 Bruno Pagani 2016-05-03 17:08:12 UTC
Sure, I’m going to reboot right now in order to have a clean dmesg, and make a suspend/resume cycle right after that, so that it also gets included.
Comment 6 Bruno Pagani 2016-05-03 17:23:12 UTC
Created attachment 215151 [details]
Full dmesg (boot+screenclose/open+suspend/resume)

Here you go for dmesg.

At 100, I do a screen close/open (for https://bugs.freedesktop.org/show_bug.cgi?id=93555, but I thought you might be interested too because some pci lines appears).

At 244, I go for a suspend/resume.

lspci following, didn’t find how to add two attachments at once.
Comment 7 Bruno Pagani 2016-05-03 17:23:49 UTC
Created attachment 215161 [details]
lspci -vvv

And here you go for lspci.
Comment 8 Bruno Pagani 2016-06-08 12:21:14 UTC
Still happening with 4.6.1 for the record.

Note You need to log in before you can comment on or make changes to this bug.