Bug 117141 - sst-acpi selects the wrong Host-IPC IRQ on some BayTrail devices
Summary: sst-acpi selects the wrong Host-IPC IRQ on some BayTrail devices
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Sound(ALSA) (show other bugs)
Hardware: Intel Linux
: P1 normal
Assignee: Jaroslav Kysela
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-25 02:04 UTC by Joel Holdsworth
Modified: 2020-09-27 23:12 UTC (History)
28 users (show)

See Also:
Kernel Version: v4.6-rc5
Subsystem:
Regression: No
Bisected commit-id:


Attachments
Fix patchset (2.19 KB, application/gzip)
2016-04-25 02:14 UTC, Joel Holdsworth
Details
ASUS T100-CHI dmidecode file (7.29 KB, text/plain)
2016-04-25 08:01 UTC, jbMacAZ
Details
DEXP Ursus 7W dmidecode file (11.32 KB, application/octet-stream)
2016-04-25 13:20 UTC, RussianNeuroMancer
Details
ASUS X205TA dmidecode file (6.52 KB, text/plain)
2016-04-25 14:14 UTC, Joshua Grisham
Details
Notion Ink Dmidecode (13.34 KB, text/plain)
2016-04-27 03:34 UTC, Kevin
Details
dmidecode output for Aspire Switch 10 SW5-012-12ER (8.71 KB, text/plain)
2016-04-30 14:54 UTC, Renze
Details
dmidecode output for the Asus Transformer T100TAF (6.59 KB, text/plain)
2016-05-04 20:27 UTC, Stephen
Details
DSDT for Lenovo Ideapad 100s (fw rev e2cn13ww) (548.35 KB, text/x-dsl)
2016-05-06 15:16 UTC, Jan Schmidt
Details
dmidecode info for Lenovo Ideadpad 100S (11.93 KB, text/plain)
2016-05-06 17:06 UTC, Jan Schmidt
Details
dmidecode for Teclast X98 Air 3G (13.66 KB, text/plain)
2016-05-07 15:38 UTC, Fabian Zaremba
Details
DSDT for Teclast X98 Air 3G (542.33 KB, text/x-dsl)
2016-05-07 15:38 UTC, Fabian Zaremba
Details
dmidecode for Acer Aspire Switch 11 SW5 (8.46 KB, text/plain)
2016-05-10 21:25 UTC, Jérôme Plût
Details
dsdt for Acer Aspire 11 SW5 (565.16 KB, text/plain)
2016-05-10 21:26 UTC, Jérôme Plût
Details
dmidecode output Acer Iconia W1-810 tablet (8.62 KB, text/plain)
2016-05-13 03:04 UTC, Marc
Details
dsdt output Acer Iconia W1-810 tablet (514.68 KB, text/plain)
2016-05-13 03:07 UTC, Marc
Details
dmidecode Lenovo miix 3-830 (14.40 KB, text/plain)
2016-05-24 08:37 UTC, Marc
Details
dsdt Lenovo miix 3-830 (510.65 KB, text/plain)
2016-05-24 08:39 UTC, Marc
Details
dmidecode from ASUS T200TA (7.51 KB, text/plain)
2016-06-03 05:27 UTC, DragonX256
Details
dsdt from ASUS T200TA (521.81 KB, text/x-dsl)
2016-06-03 05:34 UTC, DragonX256
Details
dmidecode for Acer Switch 10 SW3-013 (8.69 KB, text/plain)
2016-06-04 19:30 UTC, Francesco Cortassa Gozzi
Details
DSDT for Acer Switch 10 SW3-013 (530.29 KB, text/x-dsl)
2016-06-04 19:38 UTC, Francesco Cortassa Gozzi
Details
Toshiba Click Mini dmidecode output; UEFI firmware version 5.20 (11.58 KB, text/plain)
2016-06-15 18:02 UTC, Paul Mansfield
Details
Toshiba Click Mini DSDT file (61.17 KB, application/octet-stream)
2016-06-15 18:04 UTC, Paul Mansfield
Details
HP Stream 7 5709 dmidecode (10.35 KB, application/octet-stream)
2016-06-23 16:56 UTC, Simon-Pierre Dubé
Details
HP Stream 7 5709 DSDT (461.76 KB, text/x-dsl)
2016-06-23 16:59 UTC, Simon-Pierre Dubé
Details
Toshiba click mini DSDT.aml (61.17 KB, application/octet-stream)
2016-06-25 10:18 UTC, Paul Mansfield
Details
dmidecode-wintab-10.1 (11.38 KB, text/plain)
2016-06-28 10:31 UTC, Nikos Fytilis
Details
DSDT.dsl for wintab 10.1 (583.15 KB, text/plain)
2016-06-28 10:32 UTC, Nikos Fytilis
Details
dmidecode-flexx10 (11.35 KB, text/plain)
2016-06-28 10:34 UTC, Nikos Fytilis
Details
DSDT.dsl for Toshiba Click Mini (531.75 KB, text/x-dsl)
2016-09-02 09:07 UTC, salvo prestipino
Details
CHI asound.state (88.23 KB, application/octet-stream)
2016-12-15 22:19 UTC, jbMacAZ
Details
updated CHI asound.state (49.18 KB, application/octet-stream)
2016-12-16 07:07 UTC, jbMacAZ
Details

Description Joel Holdsworth 2016-04-25 02:04:18 UTC
On BayTrail, sst-acpi currently selects the 5th IRQ listed in the HID=80860F28 device in the DSDT. On some machines this is incorrect, and prevents the DSP from starting up.

The current behaviour is correct for...

 * coreboot
 * Intel NUC DE 3815TYBE
 * Onda V975W
 * Asus T100TA
 * HP Omni 10
 * Lenovo Thinkpad 8
 * ...and others

Where the IRQs are listed as in the following order:

0x18, 0x19, 0x1A, 0x1B, 0x1C, 0x1D

However, on some devices...

 * Asus EeeBook X205TA (bug #95681)
 * Asus T100TAF (bug #86581)
 * DEXP Ursus 7W (bug #115201)
 * Insyde W8 reference firmware (bug #93571)
 * Notion Ink Cain (bug #100361)
 * Teclast X98 Air 3g
 * Zotac PI320

...the IRQs are listed in the following order:

0x1D, 0x18, 0x19, 0x1A, 0x1B, 0x1C

On these devices the Host-IPC IRQ is the 0th IRQ rather than the last IRQ.
Comment 1 Joel Holdsworth 2016-04-25 02:14:40 UTC
Created attachment 213911 [details]
Fix patchset

This patch-set adds a quirk that overrides the IRQ index on platforms that match a certain DMI system identification. In the first instance only the Zotac PI320 is listed, but other devices are known to have the same quirk, and can be added when their DMI system ids are collected.
Comment 2 jbMacAZ 2016-04-25 08:01:55 UTC
Created attachment 213981 [details]
ASUS T100-CHI dmidecode file

re bug #115201 - will try patch set, I'll add the CHI quirk once known.

Thanks.
Comment 3 jbMacAZ 2016-04-25 08:30:07 UTC
(In reply to Joel Holdsworth from comment #1)
> Created attachment 213911 [details]
> Fix patchset
> 
> This patch-set adds a quirk that overrides the IRQ index on platforms that
> match a certain DMI system identification. In the first instance only the
> Zotac PI320 is listed, but other devices are known to have the same quirk,
> and can be added when their DMI system ids are collected.

Looks like the patches will need to update a header file too.  sst_acpi.c:240:14: "error: 'struct sst_acpi_mach' has no member named 'pdata'.
Comment 4 RussianNeuroMancer 2016-04-25 13:20:14 UTC
Created attachment 214021 [details]
DEXP Ursus 7W dmidecode file

DEXP Ursus 7W dmidecode file attached.
Comment 6 Joshua Grisham 2016-04-25 14:14:07 UTC
Created attachment 214031 [details]
ASUS X205TA dmidecode file

Attaching dmidecode for my ASUS X205TA.  Note there are multiple versions of the 205 (F205TA, X205TAW, etc) and even in Reihar's attachment here https://bugzilla.kernel.org/show_bug.cgi?id=95681#c19 it is a different version from mine I am attaching here.

Also comment from RussianNeuroMancer with email from Pierre is correct as well. Several of us have tried hacking drivers for quite some time with sst-acpi modified to use IRQ 0 instead of 5 but still no dice so far!

This change to sst-acpi is however one definite piece of the puzzle that is needed, so thank you!!!
Comment 7 Joshua Grisham 2016-04-25 14:30:35 UTC
Also Pierre has been doing some testing on this and in his code he took a little bit different approach. Not sure if this helps or not. Basically he is using CPU detection to check for Baytrail-CR vs non-CR instead of using a quirk table. 

See here:

https://github.com/plbossart/sound/commit/d525971489ddf8b39cdefabbafac42a4b12189c6

This is all just testing code and he has stated multiple times "only for testing purposes" but good to consider regardless :)
Comment 8 Kevin 2016-04-27 03:34:15 UTC
Created attachment 214511 [details]
Notion Ink Dmidecode
Comment 9 Renze 2016-04-30 14:54:14 UTC
Created attachment 214791 [details]
dmidecode output for Aspire Switch 10 SW5-012-12ER

dmidecode output for Aspire Switch 10 SW5-012-12ER
Comment 10 Stephen 2016-05-04 20:27:39 UTC
Created attachment 215301 [details]
dmidecode output for the Asus Transformer T100TAF
Comment 11 Jan Schmidt 2016-05-06 15:16:26 UTC
Created attachment 215411 [details]
DSDT for Lenovo Ideapad 100s (fw rev e2cn13ww)

Lenovo Ideapad 100s also has the 2nd interrupt order.
Comment 12 Jan Schmidt 2016-05-06 17:06:26 UTC
Created attachment 215421 [details]
dmidecode info for Lenovo Ideadpad 100S

Sorry, forgot to also attach the dmidecode info for Lenovo Ideadpad 100S
Comment 13 Fabian Zaremba 2016-05-07 15:38:02 UTC
Created attachment 215441 [details]
dmidecode for Teclast X98 Air 3G
Comment 14 Fabian Zaremba 2016-05-07 15:38:49 UTC
Created attachment 215451 [details]
DSDT for Teclast X98 Air 3G
Comment 15 Jérôme Plût 2016-05-10 21:25:31 UTC
Created attachment 215841 [details]
dmidecode for Acer Aspire Switch 11 SW5
Comment 16 Jérôme Plût 2016-05-10 21:26:32 UTC
Created attachment 215851 [details]
dsdt for Acer Aspire 11 SW5

I am attaching the dmidecode + decompiled DSDT for Acer Aspire 11 SW5, also affected by that same bug.
Comment 17 Marc 2016-05-13 03:04:11 UTC
Created attachment 216191 [details]
dmidecode output Acer Iconia W1-810 tablet

No sound on this Baytrail tablet - same issue as described in 1st post
Comment 18 Marc 2016-05-13 03:07:44 UTC
Created attachment 216201 [details]
dsdt output Acer Iconia W1-810 tablet

No sound on this Baytrail tablet - same issue as described in 1st post
Comment 19 Marc 2016-05-24 08:37:35 UTC
Created attachment 217171 [details]
dmidecode Lenovo miix 3-830

Audio not working on this Baytrail tablet - same issue
Comment 20 Marc 2016-05-24 08:39:02 UTC
Created attachment 217181 [details]
dsdt Lenovo miix 3-830

Audio not working on this Baytrail tablet - same issue
Comment 21 DragonX256 2016-06-03 05:27:35 UTC
Created attachment 218821 [details]
dmidecode from ASUS T200TA
Comment 22 DragonX256 2016-06-03 05:34:27 UTC
Created attachment 218831 [details]
dsdt from ASUS T200TA
Comment 23 Francesco Cortassa Gozzi 2016-06-04 19:29:38 UTC
dmidecode for Acer Switch 10 SW3-013
Comment 24 Francesco Cortassa Gozzi 2016-06-04 19:30:53 UTC
Created attachment 219021 [details]
dmidecode for Acer Switch 10 SW3-013
Comment 25 Francesco Cortassa Gozzi 2016-06-04 19:38:28 UTC
Created attachment 219031 [details]
DSDT for Acer Switch 10 SW3-013
Comment 26 Paul Mansfield 2016-06-15 18:00:23 UTC
Adding dmidecode for Toshiba Click Mini, another Baytrail Z3735F device with Realtek I2S 5640.
Comment 27 Paul Mansfield 2016-06-15 18:02:04 UTC
Created attachment 220161 [details]
Toshiba Click Mini dmidecode output; UEFI firmware version 5.20

Toshiba Click Mini dmidecode output; UEFI firmware version 5.20


This is another Baytrail Z3735F device with Realtek I2S 5640.
Comment 28 Paul Mansfield 2016-06-15 18:04:13 UTC
Created attachment 220171 [details]
Toshiba Click Mini DSDT file

A copy of /sys/firmware/acpi/tables/DSDT from a Toshiba Click Mini
Comment 29 Simon-Pierre Dubé 2016-06-23 16:52:09 UTC
(In reply to Paul Mansfield from comment #28)
> Created attachment 220171 [details]
> Toshiba Click Mini DSDT file
> 
> A copy of /sys/firmware/acpi/tables/DSDT from a Toshiba Click Mini

This is an cat aml, it would be a lot easier for search if you could convert it into a dsl, whit this procedure :

cat /sys/firmware/acpi/tables/DSDT > DSDT.aml
iasl -d DSDT.aml

It will give you a DSDT.dsl you can upload here.
Comment 30 Simon-Pierre Dubé 2016-06-23 16:56:18 UTC
Created attachment 221081 [details]
HP Stream 7 5709 dmidecode

dmidecode for HP Stream 7 5709 with Atom Z3735G and Realtek codec.
Comment 31 Simon-Pierre Dubé 2016-06-23 16:59:26 UTC
Created attachment 221091 [details]
HP Stream 7 5709 DSDT

DSDT for HP Stream 7 5709 with Atom Z3735G and Realtek codec.
Comment 32 Simon-Pierre Dubé 2016-06-23 17:05:44 UTC
Comment on attachment 221081 [details]
HP Stream 7 5709 dmidecode

dmidecode for HP Stream 7 5709 with Atom Z3735G and Realtek I2C device.
Comment 33 Simon-Pierre Dubé 2016-06-25 08:53:56 UTC
Changing the 0002 patch match for :
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "HP Stream 7 Tablet"),
+		}

The initialisation happen and i can finally see the device. So the quirk works for me. Thanks.
Comment 34 Paul Mansfield 2016-06-25 10:18:27 UTC
Created attachment 221161 [details]
Toshiba click mini DSDT.aml

In response to Simon-Pierre Dubé, thanks very much for your help ( https://bugzilla.kernel.org/show_bug.cgi?id=117141#c29 )
Comment 35 Simon-Pierre Dubé 2016-06-25 13:44:03 UTC
(In reply to Paul Mansfield from comment #34)
> Created attachment 221161 [details]
> Toshiba click mini DSDT.aml
> 
> In response to Simon-Pierre Dubé, thanks very much for your help (
> https://bugzilla.kernel.org/show_bug.cgi?id=117141#c29 )

In your case, can try this patch by changing the 0002 patch with

+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "SATELLITE Click Mini L9W-B"),
+		}

Then patch and recompile the kernel.

Make sure you use the menuconfig entry : <M>   ASoC Audio driver for Intel Baytrail with RT5640 codec

And not the : <M>   ASoC Audio driver for Intel Baytrail and Baytrail-CR with RT5640 codec

The second one is what's causing the issue in https://bugzilla.kernel.org/show_bug.cgi?id=117141#c3

I'm currently trying to make the second working as well, because in theory my device is a Baytrail-CR and it might be why despite getting initiated and registered, no sound is getting out.
Comment 36 Simon-Pierre Dubé 2016-06-25 13:46:13 UTC
It's in the 0003 patch you have to change it. My bad.
Comment 37 Paul Mansfield 2016-06-27 21:02:22 UTC
sadly, kernel build failed. I will review the patching
  CC [M]  sound/soc/intel/atom/sst/sst_acpi.o
sound/soc/intel/atom/sst/sst_acpi.c: In function ‘sst_acpi_probe’:
sound/soc/intel/atom/sst/sst_acpi.c:240:14: error: ‘struct sst_acpi_mach’ has no member named ‘pdata’
  pdata = mach->pdata;
              ^
sound/soc/intel/atom/sst/sst_acpi.c: At top level:
sound/soc/intel/atom/sst/sst_acpi.c:324:2: warning: excess elements in struct initializer
  {"10EC5640", "bytcr_rt5640", "intel/fw_sst_0f28.bin", "bytcr_rt5640", NULL,
  ^
sound/soc/intel/atom/sst/sst_acpi.c:324:2: warning: (near initialization for ‘sst_acpi_bytcr[0]’)
sound/soc/intel/atom/sst/sst_acpi.c:324:2: warning: excess elements in struct initializer
sound/soc/intel/atom/sst/sst_acpi.c:324:2: warning: (near initialization for ‘sst_acpi_bytcr[0]’)
sound/soc/intel/atom/sst/sst_acpi.c:325:7: warning: excess elements in struct initializer
       &byt_rvp_platform_data },
       ^
sound/soc/intel/atom/sst/sst_acpi.c:325:7: warning: (near initialization for ‘sst_acpi_bytcr[0]’)
sound/soc/intel/atom/sst/sst_acpi.c:326:2: warning: excess elements in struct initializer
  {"10EC5642", "bytcr_rt5640", "intel/fw_sst_0f28.bin", "bytcr_rt5640", NULL,
  ^
sound/soc/intel/atom/sst/sst_acpi.c:326:2: warning: (near initialization for ‘sst_acpi_bytcr[1]’)
sound/soc/intel/atom/sst/sst_acpi.c:326:2: warning: excess elements in struct initializer
sound/soc/intel/atom/sst/sst_acpi.c:326:2: warning: (near initialization for ‘sst_acpi_bytcr[1]’)
sound/soc/intel/atom/sst/sst_acpi.c:327:7: warning: excess elements in struct initializer
       &byt_rvp_platform_data },
       ^
sound/soc/intel/atom/sst/sst_acpi.c:327:7: warning: (near initialization for ‘sst_acpi_bytcr[1]’)
sound/soc/intel/atom/sst/sst_acpi.c:328:2: warning: excess elements in struct initializer
  {"INTCCFFD", "bytcr_rt5640", "intel/fw_sst_0f28.bin", "bytcr_rt5640", NULL,
  ^
sound/soc/intel/atom/sst/sst_acpi.c:328:2: warning: (near initialization for ‘sst_acpi_bytcr[2]’)
sound/soc/intel/atom/sst/sst_acpi.c:328:2: warning: excess elements in struct initializer
sound/soc/intel/atom/sst/sst_acpi.c:328:2: warning: (near initialization for ‘sst_acpi_bytcr[2]’)
sound/soc/intel/atom/sst/sst_acpi.c:329:7: warning: excess elements in struct initializer
       &byt_rvp_platform_data },
       ^
sound/soc/intel/atom/sst/sst_acpi.c:329:7: warning: (near initialization for ‘sst_acpi_bytcr[2]’)
sound/soc/intel/atom/sst/sst_acpi.c:330:2: warning: excess elements in struct initializer
  {"10EC5651", "bytcr_rt5651", "intel/fw_sst_0f28.bin", "bytcr_rt5651", NULL,
  ^
sound/soc/intel/atom/sst/sst_acpi.c:330:2: warning: (near initialization for ‘sst_acpi_bytcr[3]’)
sound/soc/intel/atom/sst/sst_acpi.c:330:2: warning: excess elements in struct initializer
sound/soc/intel/atom/sst/sst_acpi.c:330:2: warning: (near initialization for ‘sst_acpi_bytcr[3]’)
sound/soc/intel/atom/sst/sst_acpi.c:331:7: warning: excess elements in struct initializer
       &byt_rvp_platform_data },
       ^
sound/soc/intel/atom/sst/sst_acpi.c:331:7: warning: (near initialization for ‘sst_acpi_bytcr[3]’)
sound/soc/intel/atom/sst/sst_acpi.c:337:2: warning: excess elements in struct initializer
  {"10EC5670", "cht-bsw-rt5672", "intel/fw_sst_22a8.bin", "cht-bsw", NULL,
  ^
sound/soc/intel/atom/sst/sst_acpi.c:337:2: warning: (near initialization for ‘sst_acpi_chv[0]’)
sound/soc/intel/atom/sst/sst_acpi.c:337:2: warning: excess elements in struct initializer
sound/soc/intel/atom/sst/sst_acpi.c:337:2: warning: (near initialization for ‘sst_acpi_chv[0]’)
sound/soc/intel/atom/sst/sst_acpi.c:338:7: warning: excess elements in struct initializer
       &chv_platform_data },
       ^
sound/soc/intel/atom/sst/sst_acpi.c:338:7: warning: (near initialization for ‘sst_acpi_chv[0]’)
sound/soc/intel/atom/sst/sst_acpi.c:339:2: warning: excess elements in struct initializer
  {"10EC5645", "cht-bsw-rt5645", "intel/fw_sst_22a8.bin", "cht-bsw", NULL,
  ^
sound/soc/intel/atom/sst/sst_acpi.c:339:2: warning: (near initialization for ‘sst_acpi_chv[1]’)
sound/soc/intel/atom/sst/sst_acpi.c:339:2: warning: excess elements in struct initializer
sound/soc/intel/atom/sst/sst_acpi.c:339:2: warning: (near initialization for ‘sst_acpi_chv[1]’)
sound/soc/intel/atom/sst/sst_acpi.c:340:7: warning: excess elements in struct initializer
       &chv_platform_data },
       ^
sound/soc/intel/atom/sst/sst_acpi.c:340:7: warning: (near initialization for ‘sst_acpi_chv[1]’)
sound/soc/intel/atom/sst/sst_acpi.c:341:2: warning: excess elements in struct initializer
  {"10EC5650", "cht-bsw-rt5645", "intel/fw_sst_22a8.bin", "cht-bsw", NULL,
  ^
sound/soc/intel/atom/sst/sst_acpi.c:341:2: warning: (near initialization for ‘sst_acpi_chv[2]’)
sound/soc/intel/atom/sst/sst_acpi.c:341:2: warning: excess elements in struct initializer
sound/soc/intel/atom/sst/sst_acpi.c:341:2: warning: (near initialization for ‘sst_acpi_chv[2]’)
sound/soc/intel/atom/sst/sst_acpi.c:342:7: warning: excess elements in struct initializer
       &chv_platform_data },
       ^
sound/soc/intel/atom/sst/sst_acpi.c:342:7: warning: (near initialization for ‘sst_acpi_chv[2]’)
sound/soc/intel/atom/sst/sst_acpi.c:343:2: warning: excess elements in struct initializer
  {"193C9890", "cht-bsw-max98090", "intel/fw_sst_22a8.bin", "cht-bsw", NULL,
  ^
sound/soc/intel/atom/sst/sst_acpi.c:343:2: warning: (near initialization for ‘sst_acpi_chv[3]’)
sound/soc/intel/atom/sst/sst_acpi.c:343:2: warning: excess elements in struct initializer
sound/soc/intel/atom/sst/sst_acpi.c:343:2: warning: (near initialization for ‘sst_acpi_chv[3]’)
sound/soc/intel/atom/sst/sst_acpi.c:344:7: warning: excess elements in struct initializer
       &chv_platform_data },
       ^
sound/soc/intel/atom/sst/sst_acpi.c:344:7: warning: (near initialization for ‘sst_acpi_chv[3]’)
scripts/Makefile.build:258: recipe for target 'sound/soc/intel/atom/sst/sst_acpi.o' failed
make[7]: *** [sound/soc/intel/atom/sst/sst_acpi.o] Error 1
scripts/Makefile.build:407: recipe for target 'sound/soc/intel/atom/sst' failed
make[6]: *** [sound/soc/intel/atom/sst] Error 2
scripts/Makefile.build:407: recipe for target 'sound/soc/intel/atom' failed
make[5]: *** [sound/soc/intel/atom] Error 2
scripts/Makefile.build:407: recipe for target 'sound/soc/intel' failed
make[4]: *** [sound/soc/intel] Error 2
scripts/Makefile.build:407: recipe for target 'sound/soc' failed
make[3]: *** [sound/soc] Error 2
Makefile:951: recipe for target 'sound' failed
make[2]: *** [sound] Error 2
make[2]: *** Waiting for unfinished jobs....
  CC      drivers/clk/clk-gpio.o
Comment 38 Nikos Fytilis 2016-06-28 10:31:31 UTC
Created attachment 221351 [details]
dmidecode-wintab-10.1

It is a rebrand of an odys wintab 10.1
Comment 39 Nikos Fytilis 2016-06-28 10:32:41 UTC
Created attachment 221361 [details]
DSDT.dsl for wintab 10.1

dsdt.dsl for wintab 10.1
Comment 40 Nikos Fytilis 2016-06-28 10:34:16 UTC
Created attachment 221371 [details]
dmidecode-flexx10

dmidecode of flexx10
Comment 41 Paul Mansfield 2016-07-01 12:50:16 UTC
As I understand it, the Toshiba Click Mini has a Realtek ALC5640, controlled by I2C, with an I2S audio stream.

I found the datasheet for it.
http://pdf.datasheetbank.com/datasheet-download/190430/0/Realtek/ALC5640

I've found this diagram useful
http://cdn.arstechnica.net/wp-content/uploads/2013/09/Screen-Shot-2013-09-13-at-6.32.07-PM.jpg
Comment 42 Nikos Fytilis 2016-07-01 16:03:22 UTC
just to clarify, even if you fix the irq problem through DSDT or with a quirk table, what else is needed to get audio ? (I have done the first) 

P.S. dmesg reports that ssp2 is loaded, I have no DAI errors and there are no clicking sounds also that there are no tx /rx widgets. I will provide a log when I get back to that machine.
Comment 43 Simon-Pierre Dubé 2016-07-06 09:09:57 UTC
(In reply to Nikos Fytilis from comment #42)
> just to clarify, even if you fix the irq problem through DSDT or with a
> quirk table, what else is needed to get audio ? (I have done the first) 
> 
> P.S. dmesg reports that ssp2 is loaded, I have no DAI errors and there are
> no clicking sounds also that there are no tx /rx widgets. I will provide a
> log when I get back to that machine.

It's a work in progress. I suspect there's some underlying problems with the rt5649, maybe the kernel codec. I'll try the new modifications made to it on Git when i'll have free time. https://github.com/torvalds/linux/commits/master/sound/soc/codecs/rt5640.c
Comment 44 Nikos Fytilis 2016-07-06 18:44:07 UTC
> rt5649

I do not think I have that codec. From what I gather my tablet uses 5640
Comment 45 Simon-Pierre Dubé 2016-07-07 03:47:37 UTC
(In reply to Nikos Fytilis from comment #44)
> > rt5649
> 
> I do not think I have that codec. From what I gather my tablet uses 5640

Yes it's the good one.

And even 4.7-rc6 don't have fixes for those issues to what i tested.
Comment 46 salvo prestipino 2016-09-02 09:07:16 UTC
Created attachment 231891 [details]
DSDT.dsl for Toshiba Click Mini

DSDT.dsl readable for Toshiba Click Mini,
from the file I can presume that this is another device with different IRQs order
Comment 47 SergZ 2016-09-05 03:32:07 UTC
Hi! dsdt table for tablet-pc Irbis tw-36. Sound devices i see, but no sound.
Comment 48 SergZ 2016-09-05 03:39:21 UTC
(In reply to SergZ from comment #47)
> Hi! dsdt table for tablet-pc Irbis tw-36. Sound devices i see, but no sound.

https://yadi.sk/d/rGGndXZKunBeo
Comment 49 SergZ 2016-09-05 03:51:20 UTC
(In reply to SergZ from comment #47)
> Hi! dsdt table for tablet-pc Irbis tw-36. Sound devices i see, but no sound.

sorry, i not find attach button https://drive.google.com/file/d/0Bw_uaIWASLEDUG5BVXlmN01iTVE/view?usp=sharing
Comment 50 SergZ 2016-09-05 04:04:25 UTC
right file https://drive.google.com/open?id=0Bw_uaIWASLEDMWlBRXhnVHBSb3c(In reply to SergZ from comment #49)
> (In reply to SergZ from comment #47)
> > Hi! dsdt table for tablet-pc Irbis tw-36. Sound devices i see, but no
> sound.
> 
> sorry, i not find attach button
> https://drive.google.com/file/d/0Bw_uaIWASLEDUG5BVXlmN01iTVE/view?usp=sharing
Comment 51 SergZ 2016-09-05 04:05:43 UTC
(In reply to SergZ from comment #50)
> right file https://drive.google.com/open?id=0Bw_uaIWASLEDMWlBRXhnVHBSb3c

uff
Comment 53 RussianNeuroMancer 2016-11-14 07:25:04 UTC
Sorry, that was link to wrong commit. 

Right link: https://github.com/torvalds/linux/commit/a68bc0d43e1b96c374c4b03eb9baa662778357b3#diff-ad362ef9a62cab4653b68cafab76824b

> BYT-CR needs special handling to deal with BIOS issues.
> For some reason the IPC interrupt index is also modified from
> the Baytrail-T reference.
> 
> Use PUNIT BIOS config bits to infer platform details.
> Assume regular Baytrail configs if status is incorrect or
> CONFIG_IOSF_MBI is not enabled.
> 
> SSP0 routing issues are solved without dedicated firmware
> in following patches
> 
> Tested on Asus T100TA and T100TAF.
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Comment 54 MrSacs 2016-11-17 11:48:26 UTC
I've tried the kernel 4.9rc5 on my Asus x205ta. No sound yet sadly. That said I don't know if there is anything more required than just installing a new kernel. (I'd still describe myself as a new linux user).
Comment 55 Pierre Bossart 2016-11-29 18:22:33 UTC
please try with all the patches submitted in September on alsa-devel or use a stable branch at https://github.com/plbossart/sound/commits/topic/v4.8-fixes. 
Most Baytrail issues are fixed now.
Comment 56 Alps 2016-12-12 22:59:28 UTC
I tried kernel v4.9 (69973b830859bc6529a7a0468ba0d80ee5117826) from http://kernel.ubuntu.com/~kernel-ppa/mainline/v4.9/ also on a Asus X205TA and /proc/asound/cards does not list any sound card.
Comment 57 Pierre Bossart 2016-12-12 23:23:36 UTC
For X205TA issues look at bug 95681. There is a first fix to load the right drivers, we are trying to fix configuration issues now.

Most of the kernel-level issues reported here are solved and already queued up for 4.10
Comment 58 jbMacAZ 2016-12-13 00:15:21 UTC
The ASUS T100CHI sound works with 4.5 through 4.8.  With 4.9, no sound card is detected.  Is there something I need to do different with 4.9 or just keep using the older kernel(s), pending 4.10-rcx?
Comment 59 Pierre Bossart 2016-12-13 00:25:33 UTC
Yes, there was a regression with a change in alsa and the corresponding change in the clock framework not merged yet. I am not very happy that it takes 5 months to literally program 2 registers but what can I say.

You need the first commits on this branch:
https://github.com/plbossart/sound/tree/topic/v4.9-fixes
Comment 60 jbMacAZ 2016-12-13 08:21:17 UTC
(In reply to Pierre Bossart from comment #59)
> Yes, there was a regression with a change in alsa and the corresponding
> change in the clock framework not merged yet. I am not very happy that it
> takes 5 months to literally program 2 registers but what can I say.
> 
> You need the first commits on this branch:
> https://github.com/plbossart/sound/tree/topic/v4.9-fixes

It was easier for me to just zip the whole v4.9-fixes fork, and then add the few T100 (family) patches.  It worked, my CHI has sound with 4.9.  Should I expect these fixes in 4.9.1?

Anyway, thank you very much for your efforts for sound on Baytrail/Cherrytrail.
Comment 61 Pierre Bossart 2016-12-13 14:47:51 UTC
I am pretty sure the patches for the clock will not be accepted on a stable branch.

we could add a patch that falls back to the bit clock when devm_clk_get fails due to missing patches, and call it fixing a regression to push it on stable if Takashi was ok with that.
Comment 62 Takashi Iwai 2016-12-13 14:50:57 UTC
Go ahead, that sounds like a safer approach, indeed.
Comment 63 jbMacAZ 2016-12-15 06:23:17 UTC
I can test that patch if/when ready if needed.
Comment 65 jbMacAZ 2016-12-15 17:25:27 UTC
The patch checks out.  Sound works now on the T100CHI with patched 4.9.
Comment 66 jbMacAZ 2016-12-15 21:03:10 UTC
I had a problem.  I was watching a youtu.be wildlife live stream (adobe flash 11).  Sound was working as expected.  The stream (was?) paused, then I heard some clicks and pops.  Going to an older kernel confirmed a sound problem.  Weak tinny sound, right speaker also has distortion.  Speakers damaged. 

I believe I had stopped the feed and then restarted it, or the stream itself may have stuttered, I don't know exactly what stopped and restarted the stream.  Since sound started fine, I suspect a problem in an error handling or shutdown path.  While I can't rule out an improper asound.state and my ucm files are at least a month old, they were sufficient for 4.8 and earlier.

I'll help however I can, but with impaired speakers...
Comment 67 Pierre Bossart 2016-12-15 21:19:50 UTC
There was no real driver change in v4.9 that might explain this, the controls, routing and setup is identical. It'd be curious to know more if you can share your UCM setup.
Note that unfortunately you could be dealing with a pure mechanical issue. My T100TA plays with an odd vibration on the right channel also, I returned it once since the power button didn't work and I had to return my T100HA as well.
Comment 68 jbMacAZ 2016-12-15 22:19:33 UTC
Created attachment 247751 [details]
CHI asound.state

I'm looking for evidence that it is there.  I see a ucm_disabled folder in /var/lib/alsa/.  I must have missed it when I changed my ubuntu to Mint a couple months ago.  I moved the ubuntu asound.state to mint along with the then current intel firmware (august).  That was enough to get sound working on mint with 4.7.  Stale stuff and no ucm that I can find.  Chalk it up to another user error.

The asound.state (attached) has today's date.
Comment 69 jbMacAZ 2016-12-16 07:07:03 UTC
Created attachment 247801 [details]
updated CHI asound.state

I was able to reproduce the problem

The wildlife feed is
http://cams.allaboutbirds.org/channel/52/Green-and-white_Hummingbirds/
it is a youtube live stream from Peru.

Palemoon browser w/flash 11 player.  Mint Cinnamon 18.0 (Asus T100CHI)

I installed your Oct 25 UCM master, renamed my old astate.sound and rebooted.  The new astate.sound is about 35K smaller than what I had.  My speakers still work weakly - base is gone, left speaker is weak, right is distorted.

If I use the youtube player volume control, their is no problem.  If I use the system tray speaker icon to turn the volume off, when I turn the volume back on, I get static (or nothing) rather than the streaming audio.  It is very repeatable (2 for 2).  This is not a problem in older kernels.
Comment 70 jbMacAZ 2016-12-16 16:54:40 UTC
(In reply to jbMacAZ from comment #69)
> Created attachment 247801 [details]
> updated CHI asound.state
> 
> I was able to reproduce the problem
> 
> The wildlife feed is
> http://cams.allaboutbirds.org/channel/52/Green-and-white_Hummingbirds/
> it is a youtube live stream from Peru.
> 
> Palemoon browser w/flash 11 player.  Mint Cinnamon 18.0 (Asus T100CHI)
> 
> I installed your Oct 25 UCM master, renamed my old astate.sound and
> rebooted.  The new astate.sound is about 35K smaller than what I had.  My
> speakers still work weakly - base is gone, left speaker is weak, right is
> distorted.
> 
> If I use the youtube player volume control, their is no problem.  If I use
> the system tray speaker icon to turn the volume off, when I turn the volume
> back on, I get static (or nothing) rather than the streaming audio.  It is
> very repeatable (2 for 2).  This is not a problem in older kernels.

Just to clarify, I'm using the slider not the mute button.
Comment 71 jbMacAZ 2016-12-17 09:23:53 UTC
Last update on volume slider problem.  Refreshing the page in the browser will restart audio whether the slider is a 0% or higher.  The Cinnamon system tray speaker icon volume slider kills sound when it reaches zero when used with kernel 4.9.0 with the no_c_mlk_fallback patch.

I've reproduced the problem in Manjaro Cinnamon, but NOT Manjaro xfce.  I've also reproduced the problem in the v4.9-fixes fork with Mint Cinnamon.  

Finally, I've seen the problem with flash 11 and 24 and multiple flash players (youtube, ustream, jwplayer)
Comment 72 jbMacAZ 2016-12-18 17:29:30 UTC
(In reply to jbMacAZ from comment #71)

> I've reproduced the problem in Manjaro Cinnamon, but NOT Manjaro xfce.  I've
> also reproduced the problem in the v4.9-fixes fork with Mint Cinnamon.  
> 
After the latest Manjaro (testing) update, my volume slider problem is gone.  Best guess is that the system tray icon in Cinnamon stopped using a deprecated sound API.
Comment 73 jbMacAZ 2016-12-26 20:49:17 UTC
4.10-rc1 no sound card detected.  V3 of patch (comment #64) restores sound on CHI.
Comment 74 Vinod Koul 2016-12-26 20:49:34 UTC
Created attachment 248621 [details]
attachment-17218-0.html

Thanks for your email

I am out till 2nd Jan.
Please expect delayed response.

Regards
--
~Vinod
Comment 75 Pierre Bossart 2016-12-27 16:35:54 UTC
(In reply to jbMacAZ from comment #73)
> 4.10-rc1 no sound card detected.  V3 of patch (comment #64) restores sound
> on CHI.

there is a newer and safer version that was merged, see 
http://mailman.alsa-project.org/pipermail/alsa-devel/2016-December/115886.html
Comment 76 tammersyilmaz 2020-09-26 16:43:34 UTC
Dear All 

I need some help ; I have toshiba satellite click mini pc and I setup two software windows 8 and Remix Os. Remix on working but There is no sound , I check this page but I don't understand anything because I am not an expert. I think there is a solution my problen in this page but I can not understand and I need help thanks so much all...

Note You need to log in before you can comment on or make changes to this bug.