Bug 11554 - Partition check considered as error is breaking mounting in 2.6.27
Summary: Partition check considered as error is breaking mounting in 2.6.27
Status: CLOSED CODE_FIX
Alias: None
Product: IO/Storage
Classification: Unclassified
Component: Block Layer (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Jens Axboe
URL:
Keywords:
Depends on:
Blocks: Regressions-2.6.26
  Show dependency tree
 
Reported: 2008-09-12 11:36 UTC by Rafael J. Wysocki
Modified: 2008-10-12 04:43 UTC (History)
2 users (show)

See Also:
Kernel Version: 2.6.27-rc
Subsystem:
Regression: Yes
Bisected commit-id:


Attachments

Description Rafael J. Wysocki 2008-09-12 11:36:10 UTC
Subject    : Partition check considered as error is breaking mounting in 2.6.27
Submitter  : Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Date       : 2008-09-12 16:56
References : http://marc.info/?l=linux-kernel&m=122123862519434&w=4

This entry is being used for tracking a regression from 2.6.26.  Please don't
close it until the problem is fixed in the mainline.
Comment 1 Rafael J. Wysocki 2008-09-12 11:37:04 UTC
Reportedly caused by:

commit 04ebd4aee52b06a2c38127d9208546e5b96f3a19
Author: Abdel Benamrouche <draconux@gmail.com>
Date:   Fri Jul 25 01:48:26 2008 -0700

    block/ioctl.c and fs/partition/check.c: check value returned by add_partition()

    Now that add_partition() has been aught to propagate errors, let's check them.

    [akpm@linux-foundation.org: coding-style fixes]
    Signed-off-by: Abdel Benamrouche <draconux@gmail.com>
    Cc: Jens Axboe <jens.axboe@oracle.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Comment 2 Rafael J. Wysocki 2008-09-14 17:19:57 UTC
On Sunday, 14 of September 2008, Herton Ronaldo Krzesinski wrote:
> On Friday 12 September 2008 16:06:31 Rafael J. Wysocki wrote:
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> > 
> > The following bug entry is on the current list of known regressions
> > from 2.6.26.  Please verify if it still should be listed and let me know
> > (either way).
> > 
> > 
> > Bug-Entry   : http://bugzilla.kernel.org/show_bug.cgi?id=11554
> > Subject             : Partition check considered as error is breaking
> mounting in 2.6.27
> > Submitter   : Herton Ronaldo Krzesinski <herton@mandriva.com.br>
> > Date                : 2008-09-12 16:56 (1 days old)
> > References  : http://marc.info/?l=linux-kernel&m=122123862519434&w=4
> > 
> 
> Fixed now with commit 8d99f83b9478768d3a8d7d1bcd9bd182c75a0447
Comment 3 Christian Casteyde 2008-10-12 04:41:40 UTC
Just a note to add Nikon Coolpix 5900 and Swissonic MDR-2 to the faulty devices list.
Moreover, I've some questions if anybody could answer:
1. When I connect a card with a reader, I get the "p1 exceeds" error. However, when I'm connecting the camera, everything is nice, even if the partition still exceeds the device capability. There is absolutely no warning or error, neither "p1 exceeds" message. Why does the camera works and not the card reader?
2. Isn't it dangerous to store files on a partition that goes beyond the card capacité? What happens if the device gets full, or FAT tries to store at the end of the device? Is the partition size written in the FAT fs correct, to prevent that risk?

Note You need to log in before you can comment on or make changes to this bug.