Bug 115181 - Asus N750JV sound problems
Summary: Asus N750JV sound problems
Status: RESOLVED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Sound(ALSA) (show other bugs)
Hardware: All Linux
: P1 enhancement
Assignee: Jaroslav Kysela
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-23 10:28 UTC by Bobby Mihalca
Modified: 2016-03-23 15:10 UTC (History)
1 user (show)

See Also:
Kernel Version: 4.4.5
Subsystem:
Regression: No
Bisected commit-id:

Attachments
fixes (1.23 KB, patch)
2016-03-23 10:28 UTC, Bobby Mihalca 		Details | Diff
proposed patch (1.29 KB, patch)
2016-03-23 10:50 UTC, Bobby Mihalca 		Details | Diff
Asus N750JV external subwoofer fixup (1.08 KB, patch)
2016-03-23 11:59 UTC, Bobby Mihalca 		Details | Diff
Asus N750JV headphone white noise fixup (1.73 KB, patch)
2016-03-23 11:59 UTC, Bobby Mihalca 		Details | Diff
Asus N550JV headphone white noise fixup, bug 70821 (1.19 KB, patch)
2016-03-23 12:05 UTC, Bobby Mihalca 		Details | Diff
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Description Bobby Mihalca 2016-03-23 10:28:29 UTC 
Created attachment 210341 [details]
fixes

1. Subwoofer does not work out of the box on my Asus N750JV.
2. There is constant white noise from headphones (same as Bug 70821 for Asus N550JV).

I have a patch that fixes both problems.
1. is fixed by applying same config fix as for N550JV
2. is fixed by muting by amp. The same fixup sould work for N550JV and close bug 70821
Comment 1 Bobby Mihalca 2016-03-23 10:50:46 UTC 
Created attachment 210351 [details]
proposed patch
Comment 2 Takashi Iwai 2016-03-23 10:54:19 UTC 
(In reply to Bobby Mihalca from comment #0)
> Created attachment 210341 [details]
> fixes
> 
> 1. Subwoofer does not work out of the box on my Asus N750JV.
> 2. There is constant white noise from headphones (same as Bug 70821 for Asus
> N550JV).
> 
> I have a patch that fixes both problems.
> 1. is fixed by applying same config fix as for N550JV
> 2. is fixed by muting by amp. The same fixup sould work for N550JV and close
> bug 70821

The patch looks good to me.  Could you provide the proper changelog and your sign-off to get it merged into upstream?  See Documentation/SubmittingPatches for details.

We can add one more patch to apply your quirk for N550JV later, too.
Comment 3 Bobby Mihalca 2016-03-23 11:59:05 UTC 
Created attachment 210401 [details]
Asus N750JV external subwoofer fixup
Comment 4 Bobby Mihalca 2016-03-23 11:59:40 UTC 
Created attachment 210411 [details]
Asus N750JV headphone white noise fixup
Comment 5 Bobby Mihalca 2016-03-23 12:05:12 UTC 
Created attachment 210421 [details]
Asus N550JV headphone white noise fixup, bug 70821

this is untested, but given how almost identical the hardware is and bug 70821 it should work.
even if is not applyed someone with Asus N550JV and headphone white noise may find it here and maybe test it.
Comment 6 Takashi Iwai 2016-03-23 15:10:41 UTC 
Thanks.  The patches were submitted and queued for merge now.
Note You need to log in before you can comment on or make changes to this bug.