Kernel Bug Tracker – Bug 11293
2.6.27-rc2: MSI vs. ath5k suspend regression on EeePC
Last modified: 2008-08-20 12:14:00 UTC
Subject : 2.6.27-rc2: suspend regression on EeePC
Submitter : Alan Jenkins <email@example.com>
Date : 2008-08-06 18:59
References : http://thread.gmane.org/gmane.linux.kernel.kernel-testers/701
This entry is being used for tracking a regression from 2.6.26. Please don't
close it until the problem is fixed in the mainline.
Created attachment 17179 [details]
Mainline ath5k doesn't use MSI, but a patch slipped in which enabled it on resume.
Author: Pavel Roskin <firstname.lastname@example.org>
Date: Fri Jul 18 12:56:59 2008 -0400
ath5k: don't enable MSI, we cannot handle it yet
MSI is a nice thing, but we cannot enable it without changing the
interrupt handler. If we do it, we break MSI capable hardware,
specifically AR5006 chipset.
Signed-off-by: Pavel Roskin <email@example.com>
Acked-by: Nick Kossifidis <firstname.lastname@example.org>
Cc: stable <email@example.com>
Signed-off-by: John W. Linville <firstname.lastname@example.org>
Wrong! Testing confirms this regression is still present in 2.6.27-rc3. Please re-read my problem description and proposed fix.
256b152b005e319f985f50f2a910a75ba0def74f only touches the probe/remove routines in base.c. It missed the suspend/resume callbacks in hw.c which disable/re-enable MSI (which I believe is unnecessary anyway as this is done my the pci core).
Credit should go to Michael Karcher, who independently posted a similar patch on ath5k-devel several days before me.
Ah, sorry. I'll pick-up that fix in the next round.
Fixed by: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=37465c8a3ec7279e3314623d1e2d2a50c10cf79f