Bug 10948 - Support for Macbook Air in applesmc
Summary: Support for Macbook Air in applesmc
Status: RESOLVED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Hardware Monitoring (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Nicolas Boichat
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-21 09:11 UTC by Henrik Rydberg
Modified: 2008-09-17 17:25 UTC (History)
2 users (show)

See Also:
Kernel Version: v2.6.26-rc7
Subsystem:
Regression: ---
Bisected commit-id:


Attachments
Make applesmc recognize the macbook air, and assign a minimal set of sensors as a first guss (1.25 KB, patch)
2008-06-21 09:14 UTC, Henrik Rydberg
Details | Diff
Macbook Air SMC Keys (1.39 KB, text/plain)
2008-07-13 13:30 UTC, Henrik Rydberg
Details

Description Henrik Rydberg 2008-06-21 09:11:43 UTC
Latest working kernel version: unknown
Earliest failing kernel version: unknown
Distribution: ubuntu
Hardware Environment: macbook air
Software Environment: git kernel source
Problem Description: Macbook air not recognized by applesmc

Steps to reproduce: none

The Applesmc module wrongly detects the Macbook Air as a macbook, which does not have keyboard backlights. Also, the sensor set is wrong. A patch is attached which 

1) makes applesmc detect the macbook air

2) sets up a minimal set of sensors

The sensor set is most likely not complete, but at least the keyboard backlight is activated.
Comment 1 Henrik Rydberg 2008-06-21 09:14:27 UTC
Created attachment 16574 [details]
Make applesmc recognize the macbook air, and assign a minimal set of sensors as a first guss

The patch was created against the v2.6.26-rc7 kernel, with the command

diff -u  ../../../upstream-2.6/drivers/hwmon/applesmc.c applesmc.c
Comment 2 Jean Delvare 2008-06-23 09:48:05 UTC
The patch looks sane. Did you try sending it to the author of the applesmc driver, Nicolas Boichat (who I just added to Cc)? Best would be if Nicolas could review and sign the patch then send it to the lm-sensors list for upstream inclusion.
Comment 3 Henrik Rydberg 2008-06-23 10:46:17 UTC
I did not, thanks for the reply. I will standby and hope Nicolas forwards the patch.
Comment 4 Henrik Rydberg 2008-07-13 13:27:31 UTC
I sent a patch to Nicolas today, with more SMC information about the Macbook Air. If I hear nothing in a week or so, I will send it to lm-sensors directly.
Comment 5 Henrik Rydberg 2008-07-13 13:30:48 UTC
Created attachment 16804 [details]
Macbook Air SMC Keys

The list was created from instructions at http://lkml.org/lkml/2007/4/13/16

Note You need to log in before you can comment on or make changes to this bug.