I am running Ubuntu 8.04's kernel and when I resume from S3 suspend, a single message is displayed on the console about drm_sysfs_suspend, which seems to come from the function: static int drm_sysfs_suspend(struct device *dev, pm_message_t state) This doesn't appear to be an error, so presumably this should be KERN_INFO, not KERN_ERR? (less technical users often express surprise and concern when their laptop comes out of suspend and prints scary messages at them, even if it does actually work fine)
You're right, I'm not sure how that snuck in to the final upstream version. Here's the fix (sending to Linus now). diff --git a/drivers/char/drm/drm_sysfs.c b/drivers/char/drm/drm_sysfs.c index 9a32169..af211a0 100644 --- a/drivers/char/drm/drm_sysfs.c +++ b/drivers/char/drm/drm_sysfs.c @@ -34,8 +34,6 @@ static int drm_sysfs_suspend(struct device *dev, pm_message_t struct drm_minor *drm_minor = to_drm_minor(dev); struct drm_device *drm_dev = drm_minor->dev; - printk(KERN_ERR "%s\n", __func__); - if (drm_dev->driver->suspend) return drm_dev->driver->suspend(drm_dev, state);