Bug 10033 - mips yosemite_defconfig compile error
mips yosemite_defconfig compile error
Status: CLOSED CODE_FIX
Product: Platform Specific/Hardware
Classification: Unclassified
Component: MIPS
All Linux
: P1 normal
Assigned To: ralf
:
Depends on:
Blocks: 9832
  Show dependency treegraph
 
Reported: 2008-02-17 16:45 UTC by Adrian Bunk
Modified: 2008-03-14 00:59 UTC (History)
2 users (show)

See Also:
Kernel Version: 2.6.25-rc2
Tree: Mainline
Regression: Yes


Attachments
Patch to test (940 bytes, patch)
2008-03-09 05:29 UTC, Cyrill Gorcunov
Details | Diff

Description Adrian Bunk 2008-02-17 16:45:31 UTC
Subject         : mips yosemite_defconfig compile error
Submitter       : Adrian Bunk <bunk@kernel.org>
References      : http://lkml.org/lkml/2008/2/17/383
Caused-By       : Christoph Lameter <clameter@sgi.com>
                  commit 9e2779fa281cfda13ac060753d674bbcaa23367e
Comment 1 Cyrill Gorcunov 2008-03-09 05:28:23 UTC
Adiran, could you try the patch attached?
Comment 2 Cyrill Gorcunov 2008-03-09 05:29:23 UTC
Created attachment 15187 [details]
Patch to test
Comment 3 Cyrill Gorcunov 2008-03-09 09:11:54 UTC
Oops, s/Adiran/Adrian/, sorry :(
Comment 4 Adrian Bunk 2008-03-09 17:31:41 UTC
I can confirm your patch fixes the compilation.

Whether it's correct Ralf has to say.
Comment 5 Cyrill Gorcunov 2008-03-11 12:12:58 UTC
Btw, I think that 'include' from the patch I posted has to be there regardless of this bug. Look, we have in pgtable_32.h

#ifdef CONFIG_HIGHMEM
# define VMALLOC_END	(PKMAP_BASE-2*PAGE_SIZE)
#else
# define VMALLOC_END	(FIXADDR_START-2*PAGE_SIZE)
#endif

but PKMAP_BASE is defined in highmem.h so Christoph's patch just reveal this
problem. gcc was successfuly compiling MIPS before this patch 'cause of its intelligence - deffered macros exposure I think.
Comment 6 Adrian Bunk 2008-03-14 00:59:50 UTC
fixed by commit 2ac7401d11370b7a8e3a1c74aac03a021fd61048

Note You need to log in before you can comment on or make changes to this bug.