10026 – 2.6.25-rc1/2 CD/DVD burning broken

Bug 10026 - 2.6.25-rc1/2 CD/DVD burning broken

Summary: 2.6.25-rc1/2 CD/DVD burning broken

Status:	CLOSED CODE_FIX

Alias:	None

Product:	IO/Storage
Classification:	Unclassified
Component:	Block Layer (show other bugs)
Hardware:	All Linux

Importance:	P1 normal
Assignee:	Jens Axboe

URL:
Keywords:

Depends on:
Blocks:	9832
	Show dependency tree

Reported:	2008-02-17 12:57 UTC by Rafael J. Wysocki
Modified:	2008-03-02 17:23 UTC (History)
CC List:	2 users (show)

See Also:
Kernel Version:	2.6.25-rc1
Subsystem:
Regression:	Yes
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Rafael J. Wysocki 2008-02-17 12:57:58 UTC

Subject         : 2.6.25-rc1/2 CD/DVD burning broken
Submitter       : Andreas Schwab <schwab@suse.de>
Date            : 2008-02-16 21:52
References      : http://lkml.org/lkml/2008/2/16/262
Handled-By      : Jeff Garzik <jeff@garzik.org>
Handled-By      : Mark Lord <lkml@rtr.ca>

This entry is being used for tracking a regression from 2.6.24.  Please don't
close it until the problem is fixed in the mainline.

Comment 1 Mark Lord 2008-02-17 13:16:36 UTC

Here are the sign-off lines from the git commit that the reporter says broke things.  I imagine somebody (Rafael?) should "assign" this bug to one or more of those designers.


Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>

Comment 2 Mark Lord 2008-02-18 11:06:59 UTC

I wonder if this bug has anything do do with the new SATA-ATAPI "DMADIR" flag ?

What does "hdparm --Istdout" show for this drive ?

Comment 3 Andreas Schwab 2008-02-18 11:44:27 UTC

/dev/cdrom:
85c0 0000 0000 0000 0000 0000 0000 0000
0000 0000 0046 4a44 5030 3630 3933 3757
4c20 2020 2020 2020 3453 0080 0000 312e
3233 2020 2020 5049 4f4e 4545 5220 4456
442d 5257 2020 4456 522d 3131 3120 2020
2020 2020 2020 2020 2020 2020 2020 0000
0000 0f00 0000 0200 0200 0006 0000 0000
0000 0000 0000 0000 0000 0000 0000 0007
0003 0078 0078 00f0 0078 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
003c 0000 0218 4000 4000 0218 0000 4000
101f 0000 0000 0000 0000 604b 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0001 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000

/dev/cdrom:
85c0 0000 0000 0000 0000 0000 0000 0000
0000 0000 2020 2020 2020 2020 2020 2020
2020 2020 2020 2020 0000 0000 0000 444d
5032 2020 2020 4d41 5453 4849 5441 4456
442d 5220 2020 554a 2d38 3435 4520 2020
2020 2020 2020 2020 2020 2020 2020 0000
0000 0f00 0000 0200 0200 0006 0000 0000
0000 0000 0000 0000 0000 0000 0007 0407
0003 0078 0078 00f0 0078 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0078 0000 0000 0000 0000 0000 0000 0000
001f 0000 0000 0000 0000 6000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 9ca5

Comment 4 Mark Lord 2008-02-18 12:56:06 UTC

Thanks for the hdparm output.

>anything do do with the new SATA-ATAPI "DMADIR" flag ?

Not the case here (neither drive has DMADIR).  So something else is wrong.

Comment 5 Andreas Schwab 2008-02-18 14:15:57 UTC

Tested patch here:

http://marc.info/?l=linux-kernel&m=120336229403853&w=2

Comment 6 Rafael J. Wysocki 2008-02-18 14:39:41 UTC

Regressions list annotation:
Patch : http://marc.info/?l=linux-kernel&m=120336229403853&w=2

Comment 7 Rafael J. Wysocki 2008-02-24 16:43:19 UTC

Fixed by: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=14e04c3f6e64bac468f0aa38c6d47aa95b60c074

Comment 8 Andreas Schwab 2008-02-25 01:17:24 UTC

Sorry, not fixed yet.

http://marc.info/?l=linux-kernel&m=120390791527177&w=2

Comment 9 Rafael J. Wysocki 2008-02-25 03:58:45 UTC

Can you check bug #10075 and see if the patch from http://lkml.org/lkml/2008/2/24/278 works for you?

Comment 10 Andreas Schwab 2008-02-25 11:41:32 UTC

That patch changes nothing.  Most likely the bug is in cdrom_newpc_intr which apparently never sets rq->sense_len.

Comment 11 Andreas Schwab 2008-02-25 14:17:05 UTC

Patch here: http://marc.info/?l=linux-kernel&m=120397742602401&w=2

Comment 12 Rafael J. Wysocki 2008-03-02 17:23:11 UTC

Fixed by: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=bcd88ac3b2ff2eae3d0fa57a6b02d4fce5392f32

Note You need to log in before you can comment on or make changes to this bug.