Bug 9626

Summary:	drivers/usb/serial/pl2303: does not support 4348:5523
Product:	Drivers	Reporter:	Piotr Roszatycki (dexter)
Component:	USB	Assignee:	Greg Kroah-Hartman (greg)
Status:	CLOSED CODE_FIX
Severity:	low	CC:	bunk, mingo
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	2.6.24-rc6-git1	Subsystem:
Regression:	---	Bisected commit-id:
Bug Depends on:
Bug Blocks:	5089
Attachments:	support 4348:5523

Description Piotr Roszatycki 2007-12-23 12:55:13 UTC

The pl2023 does not support the following device:

4348:5523 WinChipHead USB->RS 232 adapter with Prolifec PL 2303 chipset

This driver is working with following patch (http://trash.uid0.hu/stuff/pl2303_hl340.diff):

diff -ruN linux-2.6.22.1.orig/drivers/usb/serial/pl2303.c linux-2.6.22.1/drivers/usb/serial/pl2303.c
--- linux-2.6.22.1.orig/drivers/usb/serial/pl2303.c	2007-08-09 14:30:33.610595000 +0200
+++ linux-2.6.22.1/drivers/usb/serial/pl2303.c	2007-08-09 14:36:39.594595000 +0200
@@ -84,6 +84,7 @@
 	{ USB_DEVICE(ALCOR_VENDOR_ID, ALCOR_PRODUCT_ID) },
 	{ USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_ID) },
 	{ USB_DEVICE(WS002IN_VENDOR_ID, WS002IN_PRODUCT_ID) },
+	{ USB_DEVICE(HL340_VENDOR_ID, HL340_PRODUCT_ID) },
 	{ }					/* Terminating entry */
 };
 
diff -ruN linux-2.6.22.1.orig/drivers/usb/serial/pl2303.h linux-2.6.22.1/drivers/usb/serial/pl2303.h
--- linux-2.6.22.1.orig/drivers/usb/serial/pl2303.h	2007-08-09 14:30:33.610595000 +0200
+++ linux-2.6.22.1/drivers/usb/serial/pl2303.h	2007-08-09 14:37:11.638595000 +0200
@@ -102,3 +102,7 @@
 #define WS002IN_VENDOR_ID	0x11f6
 #define WS002IN_PRODUCT_ID	0x2001
 
+/* HL HL-340 (ID: 4348:5523) */
+#define HL340_VENDOR_ID		0x4348
+#define HL340_PRODUCT_ID	0x5523
+

Comment 1 Greg Kroah-Hartman 2007-12-23 21:48:30 UTC

On Sun, Dec 23, 2007 at 12:55:14PM -0800, bugme-daemon@bugzilla.kernel.org wrote:
> The pl2023 does not support the following device:
> 
> 4348:5523 WinChipHead USB->RS 232 adapter with Prolifec PL 2303 chipset

Can you resend this patch, with the proper signed-off-by: line, to me
through email as the file Documentation/SubmittingPatches describes so I
can apply it properly and give you the correct credit for this?

Comment 2 Greg Kroah-Hartman 2008-01-01 23:02:07 UTC

patches need to go through email, not bugzilla, closing out as invalid.

Comment 3 Ingo Molnar 2008-01-02 02:14:04 UTC

Created attachment 14261 [details]
support 4348:5523

here's the merged patch for v2.6.24.

Comment 4 Ingo Molnar 2008-01-02 02:17:23 UTC

submitted via email as well.

Comment 5 Natalie Protasevich 2008-02-05 00:54:03 UTC

Thanks Ingo. I see the patch in the latest git, closing the bug.