Bug 94281
| Summary: | Synaptics Touchscreen Stops Getting Detected | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | Jianlong Liu (lvlrdka22) |
| Component: | Input Devices | Assignee: | Drivers/I2C virtual user (drivers-i2c) |
| Status: | RESOLVED CODE_FIX | ||
| Severity: | normal | CC: | alex.diewald, axfelix, lgm84, lvlrdka22, rjw, tigerite, yu.c.chen, zribi.ahmed |
| Priority: | P1 | ||
| Hardware: | Intel | ||
| OS: | Linux | ||
| Kernel Version: | 3.19-4.3 | Subsystem: | |
| Regression: | Yes | Bisected commit-id: | |
| Attachments: |
3.18.8 dmesg, working touchscreen
4.0 dmesg, touchscreen not working Patch that broke Synaptics touchscreen/stylus |
||
|
Description
Jianlong Liu
2015-03-04 19:32:33 UTC
Created attachment 169031 [details]
3.18.8 dmesg, working touchscreen
Created attachment 169041 [details]
4.0 dmesg, touchscreen not working
As far as I can tell, the only difference in directory structures in /sys/devices/LNXSYSTM:00/LNXSYBUS:00/PNP0A08:00/INT33C3:00/SYNA7500:00 are the two links (present in 3.18.8, missing in 4.0) lrwxrwxrwx 1 root root 0 Mar 4 11:43 physical_node -> ../../../../../pci0000:00/INT33C3:00/i2c-9/i2c-SYNA7500:00 lrwxrwxrwx 1 root root 0 Mar 4 11:43 physical_node1 -> ../../../../../pci0000:00/INT33C3:00/i2c-9/i2c-SYNA7500:00/0018:06CB:3AF0.0002 There's no difference for the existing INT33C3:00. I can confirm this. Dell Venue Pro 11 7130. Gentoo 3.18.9 - touchscreen working (but in my case I need reload i2c_designware_platform for appear new input device (such as /sys/devices/pci0000:00/INT33C3:00/i2c-9/i2c-SYNA7500:00)). Gentoo 3.19.1 - touchscreen not work. if try reload i2c_designware_platform I get this in dmesg: i2c_designware INT33C3:00: Unknown Synopsys component type: 0xffffffff I guess I forgot to mention, mine is a Dell Venue 11 Pro 7130 as well. I finished bisecting earlier today, and just compiled a kernel from latest upstream source with the (following) problematic patch reverted, and the touchscreen/stylus works again! Created attachment 171321 [details]
Patch that broke Synaptics touchscreen/stylus
Any progress on getting this upstream? I just came here to report this bug (also on a Venue 11 Pro, also on Arch, have locked kernel version at 3.18 for the past couple months as a result) and pleased to see that the problematic patch has apparently already been identified. Any update? Maybe bump this to 4.2 so it gets looked at? Bump to 4.3? What exactly is the process for getting this reverted upstream? For me personally, I have made some small patch that reverts the problematic change and applies the original patch from the Nvidia engineer, which works without problems for a while now. Luckily, Gentoo supports automatic patching of packages. I proposed this change to the acpi mailing list, but I did not receive a response: https://www.marc.info/?l=linux-acpi&m=143853596924508&w=1 Well, I got a response, but unfortunately it's of the "this code should work in theory" variety, and I don't have anywhere near the necessary experience with kernel drivers to try to make a case as to why we should just revert it. Anyone else in this thread want to try to jump in on the mailing list? https://www.marc.info/?l=linux-acpi&m=144668865312603&w=1 I tried the patch on kernel 4.2.3 i did not work. Not recognized in dmesg. I got around to trying the patch (I reverted the one I linked, then used that patch), and it didn't work for me either in 4.3. tried out 3.19 patched - not working The patch tries to remove synchronize_rcu_exhibited() in the original code, causing the hunk to fail, as this should be synchronize_rcu_expedited(). There's also a problem with the second hunk, the last line should read void __iomem *acpi_os_get_iomem(acpi_physical_address phys, unsigned int size) (i.e. all on one line). At the moment "size)" is on a new line on its own, which causes the patch to stop at this point and the remainder not to be applied. Appears to be fixed in 4.4! |