Bug 9414
| Summary: | Not work light of button-led with module b43 in chipset broadcom 4318 | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | Cristian Aravena Romero (caravena) |
| Component: | network-wireless | Assignee: | Rafael J. Wysocki (rjwysocki) |
| Status: | CLOSED CODE_FIX | ||
| Severity: | low | CC: | bunk, Larry.Finger, linville, mb, mingo |
| Priority: | P1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Kernel Version: | 2.6.24-rc3 | Subsystem: | |
| Regression: | Yes | Bisected commit-id: | |
| Bug Depends on: | |||
| Bug Blocks: | 9243 | ||
| Attachments: |
$dmesg
$lspci -vvn $lspci -vv $lsmod $cat /boot/config-2.6.24-rc3.071118 $uname -a Test patch |
||
|
Description
Cristian Aravena Romero
2007-11-19 20:15:19 UTC
Created attachment 13638 [details]
$dmesg
Created attachment 13639 [details]
$lspci -vvn
Created attachment 13640 [details]
$lspci -vv
Created attachment 13641 [details]
$lsmod
Created attachment 13642 [details]
$cat /boot/config-2.6.24-rc3.071118
Created attachment 13643 [details]
$uname -a
Bunk, the driver work. not-light is detail. Not regression +1. Of course a non-working driver would be a much more serious regression than a non-working LED, but still a no longer working LED is a regression. Did someone actually try to hook this led up from userspace? It's all doable through sysfs led triggers. I mean, I can not magically fix this bug, as I don't own such a device. Some help is required. @Michael: How to I help? Cristian, if 2.6.24-rc4 is still not working for you (most likely), and if you have time to track this down, you could try to figure out the exact commit that causes this regression for you. This is a clear regression, 2.6.23.1 had a working led, 2.6.24-rc does not. So one of the commits inbetween caused this problem for you. git-bisection can take quite some time though. Here's an link that explains it: http://kernel.org/pub/software/scm/git/docs/v1.4.4.4/howto/isolate-bugs-with-bisect.txt here's a quickstart: git-clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git linux-2.6.git cd linux-2.6.git git-bisect start git-bisect good v2.6.23 git-bisect bad HEAD then build the kernel that is suggested and boot into it - checking whether the led works fine or not. If the led works then do this: git-bisect good if the led does not work then do this: git-bisect bad repeat this, then after 10-15 rebuilds and reboots [ ouch! :-/ ] you'll finally arrive to a point where git-bisect outputs a "bad commit" message to you. Paste that result into this bugzilla. (also paste the contents of "git-bisect log" so that we can see your bisection results) you can then quit bisection via: git-bisect reset and can track the latest upstream kernel by doing "git-pull" in the linux-2.6.git directory. > git-bisection can take quite some time though. Here's an link that explains > it: > > > http://kernel.org/pub/software/scm/git/docs/v1.4.4.4/howto/isolate-bugs-with-bisect.txt here's another link with git-bisect info: http://www.kernel.org/doc/local/git-quick.html Cristian, any progress? Created attachment 13947 [details]
Test patch
The attached patch should fix the radio LED issue. There is still a locking problem to be solved; however, the patch is suitable for testing.
Patch is available: http://marc.info/?l=linux-wireless&m=119763729709783&w=2 Patch (for b43legacy) is available: http://marc.info/?l=linux-wireless&m=119767190601835&w=2 Fixed by: commit 1a8d122782bdabe4475f29d022c9a0c092ac9878 Author: Larry Finger <Larry.Finger@lwfinger.net> Date: Fri Dec 14 13:59:11 2007 +0100 b43: Fix rfkill radio LED http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1a8d122782bdabe4475f29d022c9a0c092ac9878 |