Bug 93701
| Summary: | radeon: two "empty" pixel lines on left side of screen, rest of screen gets slightly squished | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | Frederik vom Hofe (frederik.hofe) |
| Component: | Video(DRI - non Intel) | Assignee: | drivers_video-dri |
| Status: | RESOLVED CODE_FIX | ||
| Severity: | normal | CC: | adf.lists, alexdeucher, jwrdegoede |
| Priority: | P1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Kernel Version: | 4.0-rc1 | Subsystem: | |
| Regression: | No | Bisected commit-id: | |
| Attachments: |
dmesg
Xorg.0.log dmesg with v4.2-rc1 and 290 Xorg.0.log with v4.2-rc1 and 290 possible fix possible fix dmesg with v4.2-rc3 + 0001-drm-radeon-rework-audio-detect-v2.patch possible fix dmesg with v4.2-rc3 + 0001-drm-radeon-rework-audio-detect-v3.patch possible fix [PATCH for 4.1] drm/radeon: rework audio detect (v4) |
||
|
Description
Frederik vom Hofe
2015-02-23 17:27:28 UTC
Can you bisect? Does disabling audio fix it? Please attach your xorg log and dmesg output. Created attachment 168061 [details]
dmesg
Created attachment 168071 [details]
Xorg.0.log
Booting with radeon.audio=0 removes this phenomena. I bisected it to this change: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=baa7d8e451f030c049f83f943b9995620d6d6bd3 (In reply to Frederik vom Hofe from comment #6) > I bisected it to this change: > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/ > ?id=baa7d8e451f030c049f83f943b9995620d6d6bd3 FWIW when I hit this issue I could "mend" it without using radeon.audio=0 - all I had to do was use xrandr to do something that refreshed the display eg. off then auto. Trying this did not fix it for me: xrandr --output HDMI-0 --off; xrandr --output HDMI-0 --auto Oh, OK, my testcase is a bit different from yours in that I bring up HDMI as a second screen when in X. My symptoms also slightly different in that I get a 2 pix pink line on the left outside display area and 2 pix on right are missing. Maybe different displays behave differently. I bisected to the same commit as you. Do the patches here: https://bugs.freedesktop.org/show_bug.cgi?id=89327 help? That patchset makes no difference for me. Can you try the top 7 patches on this branch? http://cgit.freedesktop.org/~agd5f/linux/log/?h=audio-fixes The last patch (http://cgit.freedesktop.org/~agd5f/linux/patch/?id=71560b1f75e91b0eafdd8a11fb6f4e4c492f534b) does not work on 4.0-rc1: patch -p1 < ../patchset-4.0-rc1-hdmi_2/7.patch patching file drivers/gpu/drm/radeon/atombios_encoders.c Hunk #1 succeeded at 1622 (offset -4 lines). Hunk #2 FAILED at 1721. Hunk #3 succeeded at 1730 (offset -6 lines). Hunk #4 FAILED at 2178. Hunk #5 succeeded at 2196 (offset -9 lines). 2 out of 5 hunks FAILED -- saving rejects to file drivers/gpu/drm/radeon/atombios_encoders.c.rej Tried just the first 6 patches, but no difference on the screen. Ok I got the git magic working. But the audio-fixes branch still does not fix the issue for me. I've posted an updated audio-fixes branch that may help: http://cgit.freedesktop.org/~agd5f/linux/log/?h=audio-fixes Tested the patch with v4.0rc6, makes no difference for me. (In reply to Frederik vom Hofe from comment #16) > Tested the patch with v4.0rc6, makes no difference for me. Did you test all 3 patches on that branch? http://cgit.freedesktop.org/~agd5f/linux/commit/?h=audio-fixes&id=40376b60a558434abbeabeec0d39374c15cc33af http://cgit.freedesktop.org/~agd5f/linux/commit/?h=audio-fixes&id=b12f4be774671735b067f72d569c5b6d6f9ab955 http://cgit.freedesktop.org/~agd5f/linux/commit/?h=audio-fixes&id=e6704b242a1257259a5b3e8742a0411ce7dcfb48 Yes, I merged it via git. Basicly this is all I have done: git pull git checkout v4.0-rc6 git checkout -b v4.0-rc6-hdmi-patch git remote add agd5f git://people.freedesktop.org/~agd5f/linux git fetch agd5f git merge agd5f/audio-fixes Updated patches here: http://cgit.freedesktop.org/~agd5f/linux/log/?h=audio-fixes That fixes it for me. Just got a 290 that shows the same phenomena since patch revert. 2d1c18bba15daf89d75ce475ecd2068f483aa12f Revert "drm/radeon: only mark audio as connected if the monitor supports it (v3)" ... Bisected v4.1-rc5 to v4.1-rc6. Sinc v4.2-rc1 still shows the lines. Also attaching new dmesg and Xorg log, just in case. Created attachment 182061 [details]
dmesg with v4.2-rc1 and 290
Created attachment 182071 [details]
Xorg.0.log with v4.2-rc1 and 290
Created attachment 183471 [details]
possible fix
Does this patch fix the issue?
With v4.2-rc3+patch I get a black screen when the console resolution changes the first time. And my screen power led blinks like it gets no hdmi signal. So even before X starts and the pink lines show up. alt+ctrl+del does not work. But reisub does. I have no second PC on hand right now to look at it via ssh. But that can be arranged if you need to see the dmesg output. Created attachment 183491 [details]
possible fix
Updated patch.
Now the same black screen happens when X starts. can you attach the kernel log from the black screen? dmesg output. Created attachment 183511 [details]
dmesg with v4.2-rc3 + 0001-drm-radeon-rework-audio-detect-v2.patch
dmesg with v4.2-rc3 + 0001-drm-radeon-rework-audio-detect-v2.patch
Created attachment 183551 [details]
possible fix
Updated patch.
Created attachment 183561 [details]
dmesg with v4.2-rc3 + 0001-drm-radeon-rework-audio-detect-v3.patch
looks the same like v2
Created attachment 183571 [details]
possible fix
Fix stupid typo.
v4 works for me. Boots fine and no pink lines anymore. Created attachment 183611 [details] [PATCH for 4.1] drm/radeon: rework audio detect (v4) Here is the "possible fix" patch backported to 4.1 (this needed some manual fixups) I've started a Fedora kernel scratch build with this patch and asked a couple of Fedora users who are also having pink line issues to test the patch, see: https://bugzilla.redhat.com/show_bug.cgi?id=1236337 Note sofar the 4.1 version has only been compile tested! Hi, I just got feedback from one of the reporters of: https://bugzilla.redhat.com/show_bug.cgi?id=1236337 He confirms that (the 4.1 backport) of the suggested fix works. Regards, Hans The patch for 4.1 works for me, too. Ping, what is the status on this ? With 2 positive test results for the patch it would be good to get this into 4.1.x ... Already in 4.2: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=d0ea397e22f9ad0113c1dbdaab14eded050472eb and 4.1: http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?h=linux-4.1.y&id=6f9dbb525abc7b21b76bdee6558b6e706425d1a8 (In reply to Alex Deucher from comment #39) > Already in 4.2: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/ > ?id=d0ea397e22f9ad0113c1dbdaab14eded050472eb > and 4.1: > http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/ > ?h=linux-4.1.y&id=6f9dbb525abc7b21b76bdee6558b6e706425d1a8 Thanks, that is great, closing this bug then. |