Bug 93
| Summary: | 2.5.48 bttv module compile error | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | John Kim (john) |
| Component: | Video(Other) | Assignee: | Bugme Janitors Team (bugme-janitors) |
| Status: | CLOSED CODE_FIX | ||
| Severity: | normal | ||
| Priority: | P2 | ||
| Hardware: | IA-32 | ||
| OS: | Linux | ||
| Kernel Version: | Subsystem: | ||
| Regression: | --- | Bisected commit-id: | |
| Attachments: | fix the bttv compile errors | ||
|
Description
John Kim
2002-11-18 13:32:12 UTC
Oops.. the summary line should have been 2.5.48 ... Created attachment 24 [details] fix the bttv compile errors This is the minimal fix for bttv. There are many more media/audio/video patches available at http://bytesex.org/patches/2.5/ Is this fixed in mainline? If not, can we feed it upstream? It appears it's still broken in 2.5.54. gcc -Wp,-MD,drivers/media/video/.bttv-cards.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=athlon -Iinclude/asm-i386/mach-default -fomit-frame-pointer -nostdinc -iwithprefix include -DMODULE -DKBUILD_BASENAME=bttv_cards -DKBUILD_MODNAME=bttv -c -o drivers/media/video/bttv-cards.o drivers/media/video/bttv-cards.c drivers/media/video/bttv-cards.c: In function `miro_pinnacle_gpio': drivers/media/video/bttv-cards.c:1742: `AUDC_CONFIG_PINNACLE' undeclared (first use in this function) drivers/media/video/bttv-cards.c:1742: (Each undeclared identifier is reported only once drivers/media/video/bttv-cards.c:1742: for each function it appears in.) make[3]: *** [drivers/media/video/bttv-cards.o] Error 1 make[2]: *** [drivers/media/video] Error 2 make[1]: *** [drivers/media] Error 2 make: *** [drivers] Error 2 Although second part of the patch (linux-2.5.48/drivers/media/video/bttv-cards.c) has made it's way to 2.5.54, the first part of the patch (drivers/media/video/audiochip.h) did not. Applying the first part of the patch to audiochip.h does fix this particular problem with bttv-cards.c but it still breaks later at tda7432.c with following error: gcc -Wp,-MD,drivers/media/video/.tda7432.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=athlon -Iinclude/asm-i386/mach-default -fomit-frame-pointer -nostdinc -iwithprefix include -DMODULE -DKBUILD_BASENAME=tda7432 -DKBUILD_MODNAME=tda7432 -c -o drivers/media/video/tda7432.o drivers/media/video/tda7432.c drivers/media/video/tda7432.c: In function `tda7432_attach': drivers/media/video/tda7432.c:331: warning: `_MOD_INC_USE_COUNT' is deprecated (declared at include/linux/module.h:346) drivers/media/video/tda7432.c: In function `tda7432_detach': drivers/media/video/tda7432.c:354: warning: `__MOD_DEC_USE_COUNT' is deprecated (declared at include/linux/module.h:321) drivers/media/video/tda7432.c: At top level: drivers/media/video/tda7432.c:503: warning: initialization from incompatible pointer type drivers/media/video/tda7432.c:504: warning: missing braces around initializer drivers/media/video/tda7432.c:504: warning: (near initialization for `driver.name') drivers/media/video/tda7432.c:506: warning: initialization makes integer from pointer without a cast drivers/media/video/tda7432.c:506: initializer element is not computable at load time drivers/media/video/tda7432.c:506: (near initialization for `driver.name[2]') drivers/media/video/tda7432.c:507: warning: initialization makes integer from pointer without a cast drivers/media/video/tda7432.c:507: initializer element is not computable at load time drivers/media/video/tda7432.c:507: (near initialization for `driver.name[3]') drivers/media/video/tda7432.c:508: warning: initialization makes integer from pointer without a cast drivers/media/video/tda7432.c:508: initializer element is not computable at load time drivers/media/video/tda7432.c:508: (near initialization for `driver.name[4]') drivers/media/video/tda7432.c:509: initializer element is not constant drivers/media/video/tda7432.c:509: (near initialization for `driver.name') make[3]: *** [drivers/media/video/tda7432.o] Error 1 make[2]: *** [drivers/media/video] Error 2 make[1]: *** [drivers/media] Error 2 make: *** [drivers] Error 2 FYI, I'm using gcc 3.2.1 now. The fix has subsequently been incorporated into mainline kernel. The specified configuration builds correctly with 2.5.62. If the problem reoccurs, a new problem report needs to be opened. |