Bug 89371

Summary:	[PATCH]psmouse: IBM Trackpoints drift correction calibrating too quickly [patch inside]
Product:	Drivers	Reporter:	haarp (main.haarp)
Component:	Input Devices	Assignee:	drivers_input-devices
Status:	RESOLVED CODE_FIX
Severity:	normal	CC:	alan
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	3.16.5	Subsystem:
Regression:	No	Bisected commit-id:
Attachments:	Patch that exposes rstdft1 register via sysfs Patch that exposes rstdft1 register via sysfs (small change) Expose rstdft1 register for IBM trackpoints via sysfs

Description haarp 2014-12-07 12:22:01 UTC

IBM Trackpoints have a feature to compensate for drift by recalibrating themselves periodically. If for 0.5 seconds there is no change in position, it uses this as the new zero. This happens often when the trackpoint is in fact being used. This is frustrating.

Raising the time solves the problem. IBM's Trackpoint Engineering Specifications (http://blogs.epfl.ch/icenet/documents/Ykt3Eext.pdf) offer a configuration register for this (rstdft1). It just needs to be exposed by the driver, as others already are.

Comment 1 haarp 2014-12-07 12:23:29 UTC

Created attachment 159941 [details]
Patch that exposes rstdft1 register via sysfs

I have patched the sources to expose the register. Users can then modify the drift time via sysfs.

Comment 2 haarp 2014-12-07 12:31:52 UTC

Created attachment 159951 [details]
Patch that exposes rstdft1 register via sysfs (small change)

Comment 3 Alan 2014-12-08 14:51:31 UTC

Pleasee see Documentation/SubmittingPatches to submit the patch. In particular the lawyers require that every patch has a Signed-off-by:

Comment 4 haarp 2014-12-08 18:51:14 UTC

Created attachment 160061 [details]
Expose rstdft1 register for IBM trackpoints via sysfs

(In reply to Alan from comment #3)
> Pleasee see Documentation/SubmittingPatches to submit the patch. In
> particular the lawyers require that every patch has a Signed-off-by:

Thanks. I've read the doc and added the Signed-off-by line. I would really prefer to avoid the mailing list tho. I hope it's not completely unacceptable to submit patches here.

Comment 5 haarp 2014-12-18 16:27:38 UTC

I've sent the patch in and it was accepted by Dmitry Torokhov. Thanks!

Closing.