Bug 86341

Summary:	crypto/caam/caamhash.c:1180]: (error) Memory leak: edesc
Product:	Drivers	Reporter:	David Binderman (dcb314)
Component:	Other	Assignee:	drivers_other
Status:	NEW ---
Severity:	normal	CC:	alan, cristian.stoica
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	3.17.1	Subsystem:
Regression:	No	Bisected commit-id:

Description David Binderman 2014-10-15 18:32:53 UTC

Source code is

    if (dma_mapping_error(jrdev, state->buf_dma)) {
        dev_err(jrdev, "unable to map src\n");
        return -ENOMEM;
    }

Maybe better code is

    if (dma_mapping_error(jrdev, state->buf_dma)) {
        dev_err(jrdev, "unable to map src\n");
        kfree(edesc);
     
        return -ENOMEM;
    }

Comment 1 Alan 2014-10-23 14:03:59 UTC

(pinged freescale)

Comment 2 Cristian Stoica 2014-10-23 15:27:56 UTC

Thanks for reporting. There are several similar issues there.