Bug 8598

Summary: Asus M6N: no battery information in > 2.6.20
Product: ACPI Reporter: Mikhail Gusarov (dottedmag)
Component: ECAssignee: Alexey Starikovskiy (astarikovskiy)
Severity: normal CC: acpi-bugzilla, bcollins, collector, matthias.blaesing, possebaer
Priority: P2    
Hardware: i386   
OS: Linux   
Kernel Version: 2.6.22-rc4 Tree: Mainline
Regression: ---
Attachments: dmesg of (working) 2.6.20
dmesg of (non-working) 2.6.22-rc4
dmesg of (non-working) 2.6.22-rc4
acpidump output
lspci -vv
.config from 2.6.20
.config from 2.6.22-rc4
Try to find EC in DSDT if ECDT lookup fails
patch vs 2.6.23-rc1-git
Do early init only for fake _INI being present
fixed patch

Description Mikhail Gusarov 2007-06-08 05:05:23 UTC
Most recent kernel where this bug did *NOT* occur: 2.6.20
Distribution: Debian
Hardware Environment: Asus M6N notebook
Problem Description:

Main battery status/information is not reported: in 2.6.20 there were two 
directories in /proc/acpi/battery: BAT0 and BAT1 (second properly reported as 
missing, seems to be slot for extension battery), in 2.6.22-rc3 and rc4 there 
is only BAT1.

.configs, dmesgs and acpidump output are attached.
Comment 1 Mikhail Gusarov 2007-06-08 05:06:59 UTC
Created attachment 11707 [details]
dmesg of (working) 2.6.20
Comment 2 Mikhail Gusarov 2007-06-08 05:18:27 UTC
Created attachment 11708 [details]
dmesg of (non-working) 2.6.22-rc4
Comment 3 Mikhail Gusarov 2007-06-08 05:18:47 UTC
Created attachment 11709 [details]
dmesg of (non-working) 2.6.22-rc4
Comment 4 Mikhail Gusarov 2007-06-08 05:37:36 UTC
Created attachment 11711 [details]
acpidump output
Comment 5 Mikhail Gusarov 2007-06-08 05:45:14 UTC
Created attachment 11712 [details]
lspci -vv
Comment 6 Mikhail Gusarov 2007-06-08 06:09:36 UTC
Created attachment 11713 [details]
.config from 2.6.20
Comment 7 Mikhail Gusarov 2007-06-08 06:22:05 UTC
Created attachment 11714 [details]
.config from 2.6.22-rc4
Comment 8 Mikhail Gusarov 2007-06-08 06:24:06 UTC
Comment on attachment 11709 [details]
dmesg of (non-working) 2.6.22-rc4

Comment 9 Alexey Starikovskiy 2007-06-10 07:17:08 UTC
Created attachment 11724 [details]
Try to find EC in DSDT if ECDT lookup fails

Please try this patch.
Comment 10 Alexey Starikovskiy 2007-06-10 07:27:06 UTC
*** Bug 8504 has been marked as a duplicate of this bug. ***
Comment 11 Matthias Bläsing 2007-06-10 09:32:24 UTC
I'm the reportet auf the duplicate (Bug 8504) - an writing this from
2.6.22-rc4-git3. To make it short: My Battery is there and it boots *great, thanks*
Comment 12 Mikhail Gusarov 2007-06-11 02:55:45 UTC
Provided patch fixes the regression on my M6N.
Comment 13 Mikhail Gusarov 2007-07-08 23:52:49 UTC
This bugfix did not go to the 2.6.22. WTF???
Comment 14 Alexey Starikovskiy 2007-07-11 20:53:16 UTC
*** Bug 8709 has been marked as a duplicate of this bug. ***
Comment 15 Alexey Starikovskiy 2007-07-18 02:10:14 UTC
*** Bug 8477 has been marked as a duplicate of this bug. ***
Comment 16 Alexey Starikovskiy 2007-07-18 12:00:47 UTC
*** Bug 8744 has been marked as a duplicate of this bug. ***
Comment 17 Len Brown 2007-08-03 15:06:37 UTC
Created attachment 12242 [details]
patch vs 2.6.23-rc1-git

this refreshed patch from Alexey is in acpi-test
Comment 18 Len Brown 2007-08-20 13:31:42 UTC
shipped in 2.6.23-rc3
Comment 19 Fu Michael 2007-10-10 01:03:27 UTC
*** Bug 8493 has been marked as a duplicate of this bug. ***
Comment 20 Alexey Starikovskiy 2007-10-30 13:22:55 UTC
Created attachment 13355 [details]
Do early init only for fake _INI being present

Previous patch causes too many problems for other machines. Try limit early inits to only EC with _INI method. Please test that it does not cause regressions for you.
Comment 21 Thomas Schwarzgruber 2007-11-02 12:45:26 UTC
Applied patch to 2.6.24-rc1-g5307cc1a and Battery 0 is not shown again:

bash-3.00$ dmesg | grep ACPI
ACPI: AC Adapter [AC] (off-line)
ACPI: Battery Slot [BAT1] (battery absent)
Comment 22 Alexey Starikovskiy 2007-11-02 13:11:20 UTC
Created attachment 13385 [details]
fixed patch

Sorry, there was typo in previous patch. Could you please test this one?
Comment 23 Thomas Schwarzgruber 2007-11-05 01:38:54 UTC
That one works for me.
Comment 24 Mikhail Gusarov 2007-11-05 14:17:38 UTC
Works for me too.
Comment 25 Len Brown 2007-11-18 22:48:34 UTC
(ACPI: EC: Don't init EC early if it has no _INI)
applied to acpi test branch
Comment 26 Len Brown 2008-06-13 20:30:09 UTC
shipped in 2.6.24-rc4 -- closed

commit 5870a8cd23181703cc76f88f630372f8602c7648
Author: Alexey Starikovskiy <astarikovskiy@suse.de>
Date:   Thu Nov 15 21:52:47 2007 +0300

    ACPI: EC: Don't init EC early if it has no _INI
    Option to init EC early inserted to handle #8598 ASUS problem,
    introduced several others.
    EC driver in this particular case has fake _INI method, not present on
    other machines, which don't need or break from this workaround, so lets use
    its presence as a flag for early init.
    Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
    Signed-off-by: Len Brown <len.brown@intel.com>