Bug 82681

Summary:	gpu/drm/radeon/cik.c:1849: bad nested conditions ?
Product:	Drivers	Reporter:	David Binderman (dcb314)
Component:	Video(DRI - non Intel)	Assignee:	drivers_video-dri
Status:	RESOLVED WILL_NOT_FIX
Severity:	normal	CC:	alan, alexdeucher
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	3.17-rc1	Subsystem:
Regression:	No	Bisected commit-id:

Description David Binderman 2014-08-18 08:44:18 UTC

[linux-3.17-rc1/drivers/gpu/drm/radeon/cik.c:1849] -> [linux-3.17-rc1/drivers/gpu/drm/radeon/cik.c:1850]: (warning) Opposite conditions in nested 'if' blocks lead to a dead code block.

    if (running == 0) {
        if (running) {

Comment 1 David Binderman 2014-08-18 08:46:18 UTC

Same thing elsewhere

[linux-3.17-rc1/drivers/gpu/drm/radeon/si.c:1564] -> [linux-3.17-rc1/drivers/gpu/drm/radeon/si.c:1565]: (warning) Opposite conditions in nested 'if' blocks lead to a dead code block.

Comment 2 Alex Deucher 2014-08-21 16:55:03 UTC

Earlier versions of the code had the core part of the loop split out into a separate function so it needed the additional checks in case it was called from elsewhere.  I left them in as a reminder in case the code is ever restructured.