Bug 8097

Summary: Build failure on SPARC64 in floppy.c (CONFIG_BLK_DEV_FD=y)
Product: IO/Storage Reporter: Horst H. von Brand (vonbrand)
Component: OtherAssignee: io_other
Status: CLOSED CODE_FIX    
Severity: normal CC: bunk
Priority: P2    
Hardware: i386   
OS: Linux   
Kernel Version: 2.6.21-rc1 (git c68644d) Subsystem:
Regression: --- Bisected commit-id:
Attachments: Config file for failed build

Description Horst H. von Brand 2007-02-27 09:02:27 UTC 
Most recent kernel where this bug did *NOT* occur: 2.6.20
Distribution: Aurora Corona
Hardware Environment: SPARCstation 1+
Software Environment:
Problem Description:
Build fails with:

  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1
drivers/built-in.o: In function `floppy_shutdown':
floppy.c:(.text+0x33edc): undefined reference to `dma_spin_lock'
floppy.c:(.text+0x33f0c): undefined reference to `dma_spin_lock'
floppy.c:(.text+0x33f20): undefined reference to `dma_spin_lock'
drivers/built-in.o: In function `floppy_interrupt':
(.text+0x33fe8): undefined reference to `dma_spin_lock'
drivers/built-in.o: In function `floppy_interrupt':
(.text+0x33ff4): undefined reference to `dma_spin_lock'
drivers/built-in.o:(.text+0x3401c): more undefined references to `dma_spin_lock'
follow
make: *** [.tmp_vmlinux1] Error 1

Steps to reproduce:
Compile kernel ;-)
Comment 1 Adrian Bunk 2007-02-27 15:18:31 UTC 
Please attach your .config.
Comment 2 Horst H. von Brand 2007-02-28 05:04:35 UTC 
Created attachment 10552 [details]
Config file for failed build
Comment 3 Horst H. von Brand 2007-02-28 05:07:50 UTC 
dma_spin_lock is used by macros defined in include/asm-sparc64/floppy.h, and it
is defined in kernel/dma.c AFAICS, but that file was not compiled here (?) (no
kernel/dma.o at any rate).
Comment 4 Horst H. von Brand 2007-02-28 05:18:04 UTC 
kernel/Makefile contains:

  obj-$(CONFIG_GENERIC_ISA_DMA) += dma.o

this is surely wrong on a SPARCstation Ultra 1...
Comment 5 Adrian Bunk 2007-03-13 03:39:06 UTC 
Fixed in 2.6.21-rc3.