Bug 80521
| Summary: | media/davinci_vpfe/dm365_ipipeif.c:210: poor error testing ? | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | David Binderman (dcb314) |
| Component: | Staging | Assignee: | drivers_staging (drivers_staging) |
| Status: | NEW --- | ||
| Severity: | normal | CC: | andrey_utkin |
| Priority: | P1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Kernel Version: | 3.16-rc5 | Subsystem: | |
| Regression: | No | Bisected commit-id: | |
[linux-3.16-rc5/drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:210]: (style) Checking if unsigned variable 'val' is less than zero. val = get_oneshot_mode(ipipeif->input); if (val < 0) { pr_err("ipipeif: links setup required"); return -EINVAL; } but static int get_oneshot_mode(enum ipipeif_input_entity input)