Bug 80481

Summary: drivers/net/wireless/ath/ath9k/spectral.c: 4 * pointless test ?
Product: Drivers Reporter: David Binderman (dcb314)
Component: network-wirelessAssignee: drivers_network-wireless (drivers_network-wireless)
Status: NEW ---    
Severity: low CC: andrey_utkin
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 3.15-rc5 Subsystem:
Regression: No Bisected commit-id:

Description David Binderman 2014-07-17 12:54:38 UTC
1.

[linux-3.16-rc5/drivers/net/wireless/ath/ath9k/spectral.c:316]: (style) Checking if unsigned variable 'val' is less than zero.

Source code is

    if (val < 0 || val > 1)
        return -EINVAL;

2.

[linux-3.16-rc5/drivers/net/wireless/ath/ath9k/spectral.c:364]: (style) Checking if unsigned variable 'val' is less than zero.
[linux-3.16-rc5/drivers/net/wireless/ath/ath9k/spectral.c:412]: (style) Checking if unsigned variable 'val' is less than zero.
[linux-3.16-rc5/drivers/net/wireless/ath/ath9k/spectral.c:460]: (style) Checking if unsigned variable 'val' is less than zero.

Duplicates.
Comment 1 Andrey Utkin 2014-07-17 14:05:08 UTC
Thanks, patch submitted: https://patchwork.kernel.org/patch/4575591/