Bug 80461

Summary: misc/sgi-gru/grukdump.c:199: pointless code ?
Product: Drivers Reporter: David Binderman (dcb314)
Component: OtherAssignee: drivers_other
Status: NEW ---    
Severity: low CC: andrey_utkin
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 3.16-rc5 Subsystem:
Regression: No Bisected commit-id:

Description David Binderman 2014-07-17 12:48:29 UTC
[linux-3.16-rc5/drivers/misc/sgi-gru/grukdump.c:199]: (style) Checking if unsigned variable 'gid' is less than zero.

    if (req.gid >= gru_max_gids || req.gid < 0)
        return -EINVAL;
Comment 1 Andrey Utkin 2014-07-17 14:05:48 UTC
Thanks, patch submitted: https://patchwork.kernel.org/patch/4575581/