Bug 80431
Summary: | drivers/edac/edac_module.c:31: pointless code ? | ||
---|---|---|---|
Product: | Drivers | Reporter: | David Binderman (dcb314) |
Component: | EDAC | Assignee: | drivers_edac (drivers_edac) |
Status: | NEW --- | ||
Severity: | low | CC: | andrey_utkin |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 3.16-rc5 | Subsystem: | |
Regression: | No | Bisected commit-id: |
Description
David Binderman
2014-07-16 20:37:20 UTC
linux-next has it fixed. But it somehow didn't get into linux-stable up to now. commit 6866b390562b2c948c6f6fc2a5c103f090a02e01 Author: Fabian Frederick <fabf@skynet.be> Date: Mon Jun 9 21:20:18 2014 +0200 EDAC, edac_module.c: Remove unnecessary test on unsigned value unsigned long value is never < 0. Cc: Doug Thompson <dougthompson@xmission.com> Signed-off-by: Fabian Frederick <fabf@skynet.be> Link: http://lkml.kernel.org/r/1402341618-10674-1-git-send-email-fabf@skynet.be Signed-off-by: Borislav Petkov <bp@suse.de> diff --git a/drivers/edac/edac_module.c b/drivers/edac/edac_module.c index a66941f..e6d1691 100644 --- a/drivers/edac/edac_module.c +++ b/drivers/edac/edac_module.c @@ -28,7 +28,7 @@ static int edac_set_debug_level(const char *buf, struct kernel_param *kp) if (ret) return ret; - if (val < 0 || val > 4) + if (val > 4) return -EINVAL; return param_set_int(buf, kp); Notified maintainers: http://marc.info/?l=linux-kernel&m=140559999820015&w=2 |