Bug 80411
| Summary: | char/dsp56k.c:386: pointless code ? | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | David Binderman (dcb314) |
| Component: | Other | Assignee: | drivers_other |
| Status: | NEW --- | ||
| Severity: | low | CC: | andrey_utkin |
| Priority: | P1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Kernel Version: | 3.16-rc5 | Subsystem: | |
| Regression: | No | Bisected commit-id: | |
Thanks, patch submitted: https://patchwork.kernel.org/patch/4574851/ |
[linux-3.16-rc5/drivers/char/dsp56k.c:386]: (style) Checking if unsigned variable 'arg' is less than zero. Source code is if (arg > 31 || arg < 0) return -EINVAL; But static long dsp56k_ioctl(struct file *file, unsigned int cmd, unsigned long arg) Suggest new code if (arg > 31) return -EINVAL;