Bug 79821

Summary: ethernet/freescale/gianfar_ethtool.c:1584: possible bad expression ?
Product: Networking Reporter: David Binderman (dcb314)
Component: OtherAssignee: Stephen Hemminger (stephen)
Status: NEW ---    
Severity: normal CC: sanjeevsharmaengg
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 3.16-rc4 Subsystem:
Regression: No Bisected commit-id:

Description David Binderman 2014-07-10 11:25:44 UTC 
[linux-3.16-rc4/drivers/net/ethernet/freescale/gianfar_ethtool.c:1584]: (style) Same expression on both sides of '|'.

    for (; i < MAX_FILER_IDX - 1 && (tab->fe[i].ctrl | tab->fe[i].ctrl);
Comment 1 sanjeevsharma 2015-01-12 07:01:37 UTC 
Hello Stephen,

IMO the correct expression should be as below.

for (; (i < MAX_FILER_IDX - 1) && ( i < tab->fe[i].ctrl);
Comment 2 sanjeevsharma 2015-02-05 10:49:26 UTC 
Hello,

Patch has been accepted and Now I can mark this Resolved Fixed.

https://lkml.org/lkml/2015/2/4/705