Bug 79801
| Summary: | pvrusb2/pvrusb2-v4l2.c:956: possible bad if test ? | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | David Binderman (dcb314) |
| Component: | USB | Assignee: | Greg Kroah-Hartman (greg) |
| Status: | NEW --- | ||
| Severity: | normal | CC: | andrey_utkin |
| Priority: | P1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Kernel Version: | 3.16-rc4 | Subsystem: | |
| Regression: | No | Bisected commit-id: | |
Submitted a patch: https://patchwork.kernel.org/patch/4523401/ Thanks for report. On Thu, Jul 10, 2014 at 11:06:50AM +0000, bugzilla-daemon@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=79801 > > Bug ID: 79801 > Summary: pvrusb2/pvrusb2-v4l2.c:956: possible bad if test ? Please send this to the people identified with the scripts/get_maintainer.pl tool for this file. (In reply to Greg Kroah-Hartman from comment #2) > Please send this to the people identified with the > scripts/get_maintainer.pl tool for this file. I did. To: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Cc: m.chehab@samsung.com, isely@pobox.com, dcb314@hotmail.com. |
[linux-3.16-rc4/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c:956]: (style) Expression is always false because 'else if' condition matches previous condition at line 952. if (pvrusb2_debug & PVR2_TRACE_V4LIOCTL) { pvr2_trace(PVR2_TRACE_V4LIOCTL, "pvr2_v4l2_do_ioctl failure, ret=%ld", ret); } else { if (pvrusb2_debug & PVR2_TRACE_V4LIOCTL) { Suggest code rework.