Bug 79781

Summary: mach-s3c24xx/mach-osiris-dvs.c:81: possible bad test ?
Product: Platform Specific/Hardware Reporter: David Binderman (dcb314)
Component: ARMAssignee: linux-arm-kernel (linux-arm-kernel)
Status: NEW ---    
Severity: normal CC: andrey_utkin
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 3.16-rc4 Subsystem:
Regression: No Bisected commit-id:

Description David Binderman 2014-07-10 09:06:31 UTC 
[linux-3.16-rc4/arch/arm/mach-s3c24xx/mach-osiris-dvs.c:81]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.

        if (!old_dvs & new_dvs ||
            !cur_dvs & new_dvs) {

Maybe someone got & and && muxed up. Suggest code rework.

[linux-3.16-rc4/arch/arm/mach-s3c24xx/mach-osiris-dvs.c:82]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.

Duplicate.
Comment 1 Andrey Utkin 2014-07-10 12:48:30 UTC 
Submitted a patch: https://patchwork.kernel.org/patch/4523481/
Thanks for report.