Bug 7814

Summary:	add vendor/device id for Option GT Max 3.6 cards
Product:	Drivers	Reporter:	Garret D'Amore (garrett_damore)
Component:	USB	Assignee:	Greg Kroah-Hartman (greg)
Status:	CLOSED CODE_FIX
Severity:	normal	CC:	bunk
Priority:	P2
Hardware:	i386
OS:	Linux
Kernel Version:	2.6.19	Subsystem:
Regression:	---	Bisected commit-id:

Description Garret D'Amore 2007-01-12 15:47:54 UTC

Most recent kernel where this bug did *NOT* occur: none
Distribution: ubuntu, LFS
Hardware Environment: x86 laptop (Centrino M)
Software Environment:
Problem Description:

Cingular has recently started selling the Option GT Max GSM/HSDPA card.  This
device acts like the other Option devices, except that it has a unique device id
of 0x6701.  Adding it to the appropriate table in drivers/usb/serial/option.c
allows it to work.  (I've tested it, and can submit diffs if so desired.)

The card uses the Option vendor id (0x0af0) and a new device id of 6701.

I recommed that the macro for the device id be called:

#define OPTION_PRODUCT_GTMAX36   0x6701

Steps to reproduce:

Comment 1 Greg Kroah-Hartman 2007-01-12 16:02:03 UTC

On Fri, Jan 12, 2007 at 03:54:45PM -0800, bugme-daemon@bugzilla.kernel.org wrote:
> The card uses the Option vendor id (0x0af0) and a new device id of 6701.
> 
> I recommed that the macro for the device id be called:
> 
> #define OPTION_PRODUCT_GTMAX36   0x6701

Care to just send me a patch for the driver, adding the device ids as
per the Documentation/SubmittingPatches file?  That way I can add the
device ids and properly credit you for the change (you get your name in
the kernel tree.)

thanks,

greg k-h

Comment 2 Garret D'Amore 2007-01-12 17:03:36 UTC

Here you go!

--- linux-2.6.19.2/drivers/usb/serial/option.c.orig     2007-01-12 17:07:28.9430
47601 -0800
+++ linux-2.6.19.2/drivers/usb/serial/option.c  2007-01-12 17:08:21.055672001 -0
800
@@ -78,6 +78,7 @@ static int  option_send_setup(struct usb
 #define OPTION_PRODUCT_FUSION2          0x6300
 #define OPTION_PRODUCT_COBRA            0x6500
 #define OPTION_PRODUCT_COBRA2           0x6600
+#define OPTION_PRODUCT_GTMAX36          0x6701
 #define HUAWEI_PRODUCT_E600             0x1001
 #define AUDIOVOX_PRODUCT_AIRCARD        0x0112
 #define NOVATELWIRELESS_PRODUCT_U740    0x1400
@@ -89,6 +90,7 @@ static struct usb_device_id option_ids[]
        { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_FUSION2) },
        { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_COBRA) },
        { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_COBRA2) },
+       { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_GTMAX36) },
        { USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E600) },
        { USB_DEVICE(AUDIOVOX_VENDOR_ID, AUDIOVOX_PRODUCT_AIRCARD) },
        { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID,NOVATELWIRELESS_PRODUCT_U740) },
@@ -102,6 +104,7 @@ static struct usb_device_id option_ids1[
        { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_FUSION2) },
        { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_COBRA) },
        { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_COBRA2) },
+       { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_GTMAX36) },
        { USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E600) },
        { USB_DEVICE(AUDIOVOX_VENDOR_ID, AUDIOVOX_PRODUCT_AIRCARD) },
        { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID,NOVATELWIRELESS_PRODUCT_U740) },

Comment 3 Adrian Bunk 2007-02-26 14:59:52 UTC

The patch from this bug was included in 2.6.20.