Bug 78041

Summary: staging/rtl8192ee/base.c:830: bad if test ?
Product: Drivers Reporter: David Binderman (dcb314)
Component: StagingAssignee: drivers_staging (drivers_staging)
Status: NEW ---    
Severity: normal CC: andrey_utkin
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 3.16-rc1 Subsystem:
Regression: No Bisected commit-id:

Description David Binderman 2014-06-16 09:12:16 UTC
[linux-3.16-rc1/drivers/staging/rtl8192ee/base.c:830]: (style) Expression '(X & 0xc) != 0xc0' is always true.

Source code is

    if ((get_rf_type(rtlphy) == RF_2T2R) &&
        (map & 0x000c) != 0x000c0) {

Suggest code rework.
Comment 1 Andrey Utkin 2014-07-04 23:43:51 UTC
Posted a patch: https://patchwork.kernel.org/patch/4486051/
Thank you for report.