Bug 7747

Summary:	sis190 fails to set MAC address from EEPROM
Product:	Drivers	Reporter:	sleepy
Component:	Network	Assignee:	Francois Romieu (romieu)
Status:	RESOLVED CODE_FIX
Severity:	normal	CC:	bunk, romieu
Priority:	P2
Hardware:	i386
OS:	Linux
Kernel Version:	2.6.19.1	Subsystem:
Regression:	---	Bisected commit-id:

Description sleepy 2006-12-27 16:24:26 UTC

Most recent kernel where this bug did *NOT* occur:
Distribution:
Hardware Environment:
Software Environment:
Problem Description:

sis190 fail to set MAC address (HWaddr) from EEPROM.

try following patch

--- sis190.c.orig       2006-12-12 04:32:53.000000000 +0900
+++ sis190.c    2006-12-28 09:12:20.000000000 +0900
@@ -1559,7 +1559,7 @@
        for (i = 0; i < MAC_ADDR_LEN / 2; i++) {
                __le16 w = sis190_read_eeprom(ioaddr, EEPROMMACAddr + i);

-               ((u16 *)dev->dev_addr)[0] = le16_to_cpu(w);
+               ((u16 *)dev->dev_addr)[i] = le16_to_cpu(w);
        }

        sis190_set_rgmii(tp, sis190_read_eeprom(ioaddr, EEPROMInfo));


Steps to reproduce:

Comment 1 Andrew Morton 2006-12-28 15:00:31 UTC

Thanks, I queued the fix.