Bug 7255
Summary: | sata-via doesn't detect anymore disks attached to VIA vt6421 (CONFIG_PCI_MULTITHREAD_PROBE) | ||
---|---|---|---|
Product: | IO/Storage | Reporter: | Thierry Vignaud (thierry.vignaud) |
Component: | Serial ATA | Assignee: | Tejun Heo (htejun) |
Status: | CLOSED INVALID | ||
Severity: | high | CC: | bunk, greg, htejun, jacliburn |
Priority: | P2 | ||
Hardware: | i386 | ||
OS: | Linux | ||
Kernel Version: | 2.6.19-rc5 | Subsystem: | |
Regression: | --- | Bisected commit-id: | |
Attachments: | sata_via badly chokes with PCI multithread probing one |
Description
Thierry Vignaud
2006-10-03 07:46:54 UTC
still valid as of 2.6.19-rc1 (and no later commits on that corner) Btw, there's no real changes in sata_via between working 2.6.18 and broken 2.6.19-rcX besides formating changes, name changes, ... So it looks like the error management changes in core libata are affecting sata_via (maybe exposing a previously hidden issue?). git bisect may be an option... ...also you said you managed to fix it at some point; explaining how would be nice. I got it to boot one while Tejun Heo was updating his EH bits but since latest libata it always fine. Yesterday I altered sata_via so that it used vt6420_prereset for vt6421 too like I did earlier. It didn't worked. I traced sata_via and found out it was looping (nearly freezing a kernel thread in fact in vt6420_prereset). I eventually saw the light this night and disabled CONFIG_PCI_MULTITHREAD_PROBE. Then it eventually saw my discs and enabled me to boot that machine with 2.6.19-rc5-mm1 Created attachment 9502 [details]
sata_via badly chokes with PCI multithread probing one
CONFIG_PCI_MULTITHREAD_PROBE makes sata_via slowly looping in vt6420_prereset
when using vt6420_error_handler() instead of ata_bmdma_error_handler().
(I didn't bother checking where it actually chokes when using the default
ata_bmdma_error_handler().
I successfully booted 2.6.19-rc5-mm1 with multithread probing disabled
So, are you saying that disabling PCI multithread probing fixed all the problem w/o modifying sata_via? Indeed. okay, closing the bug then. Yes, this is a known issue with many sata drives, that is the way they currently work, sorry. |