Bug 70081

Summary:	mutex_unlock is missed in function (drm_crtc_init) in file (linux-3.13/drivers/gpu/drm/drm_crtc.c)
Product:	Drivers	Reporter:	Ahmed Tamrawi (atamrawi)
Component:	Other	Assignee:	drivers_other
Status:	RESOLVED INVALID
Severity:	normal	CC:	alan
Priority:	P1
Hardware:	x86-64
OS:	Linux
Kernel Version:	3.13	Subsystem:
Regression:	No	Bisected commit-id:

Description Ahmed Tamrawi 2014-02-05 17:23:00 UTC

In function (drm_crtc_init) in file (linux-3.13/drivers/gpu/drm/drm_crtc.c):

The structure (crtc->mutex) gets successfully locked at line (636) by (drm_modeset_lock_all(dev)), but it is not unlocked before line (637) where the structure is reinitialized. After line (637) the re-initialized structure gets locked at (638) and unlocked at line (650) by (drm_modeset_unlock_all(dev)).

A possible solution is to call (drm_modeset_unlock_all(dev)) before the re-initialization line (637).

Comment 1 Alan 2014-02-07 11:24:26 UTC

Intentional