Bug 6972

Summary:	alsa 1.0.12rc1 does not correctly make fm801 module if compiled extenally
Product:	Drivers	Reporter:	Andy Shevchenko (andy.shevchenko)
Component:	Sound(ALSA)	Assignee:	Jaroslav Kysela (perex)
Status:	REJECTED DUPLICATE
Severity:	normal
Priority:	P2
Hardware:	i386
OS:	Linux
Kernel Version:	2.6.17	Subsystem:
Regression:	---	Bisected commit-id:

Description Andy Shevchenko 2006-08-08 02:23:45 UTC

When I try to compile official alsa tarball 1.0.12rc1 the fm801 module does not 
include TEA575X radio support due to incorrectness in fm801.c as I think.

[andy@amd64 alsa-driver-1.0.12rc1]$ find . -name "*.h" -o -name "*.c" -type f | 
xargs grep -n CONFIG_VIDEO_DEV
./alsa-kernel/pci/fm801.c:39:#if (defined(CONFIG_SND_FM801_TEA575X) || 
defined(CONFIG_SND_FM801_TEA575X_MODULE)) && (defined(CONFIG_VIDEO_DEV) || 
defined(CONFIG_VIDEO_DEV_MODULE))
./include/linux/autoconf.h:2216:#define CONFIG_VIDEO_DEV_MODULE 1
./include/linux/autoconf.h:3335:#undef CONFIG_VIDEO_DEV_MODULE
./include/config1.h:124:/* #undef CONFIG_VIDEO_DEV_MODULE */

As you can see above the issue reproduce with CONFIG_VIDEO_DEV_MODULE define.
When external build of alsa is used the CONFIG_SND_DEV is setuped to 'y'. 
ASLA's configure script hacks autoconf.h due to previous codition.
And we have interesting lines in autoconf.h.

grep shows that CONFIG_VIDEO_DEV* options are used only in fm801.c. I think the 
solution is simple drop this requirements in the fm801 module (also, I have 
checked this theory and my rebuild is fine).

Comment 1 Andy Shevchenko 2006-08-08 02:26:23 UTC


*** This bug has been marked as a duplicate of 6458 ***