Bug 69441

Summary:	WARNING: CPU: 0 PID: 4992 at fs/sysfs/group.c:214 sysfs_remove_group+0xc6/0xd0()
Product:	SCSI Drivers	Reporter:	Igor Raits (igor.raits)
Component:	Other	Assignee:	scsi_drivers-other
Status:	REOPENED ---
Severity:	normal	CC:	igor.raits, joe.lawrence, kernel, pahan, stern
Priority:	P1
Hardware:	All
OS:	Linux
See Also:	https://bugzilla.redhat.com/show_bug.cgi?id=1030988
Kernel Version:	3.13.0-1.fc21.x86_64	Subsystem:
Regression:	No	Bisected commit-id:
Attachments:	dmesg another warning

Description Igor Raits 2014-01-26 12:40:15 UTC

WARNING: CPU: 0 PID: 8625 at fs/sysfs/group.c:214 sysfs_remove_group+0xc6/0xd0()
sysfs group ffffffff81cb0680 not found for kobject 'target6:0:0'
Modules linked in: usb_storage rfcomm ccm fuse ipt_MASQUERADE xt_CHECKSUM tun ip6t_rpfilter ip6t_REJECT xt_conntrack bnep ebtable_nat ebtable_broute bridge stp llc ebtable_filter ebtables ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack iptable_mangle iptable_security iptable_raw iTCO_wdt iTCO_vendor_support vfat fat snd_hda_codec_hdmi snd_hda_codec_realtek x86_pkg_temp_thermal coretemp kvm_intel kvm snd_hda_intel snd_hda_codec snd_hwdep snd_seq crct10dif_pclmul snd_seq_device arc4 crc32_pclmul snd_pcm crc32c_intel iwldvm ghash_clmulni_intel microcode mac80211 uvcvideo cdc_mbim serio_raw videobuf2_vmalloc videobuf2_memops i2c_i801 cdc_ncm btusb videobuf2_core usbnet videodev bluetooth iwlwifi media cfg80211 mii sdhci_pci sdhci cdc_wdm cdc_acm mmc_core snd_page_alloc lpc_ich mfd_core shpchp snd_timer mei_me mei wmi thinkpad_acpi snd soundcore rfkill tpm_tis tpm nfsd auth_rpcgss nfs_acl lockd sunrpc i915 i2c_algo_bit drm_kms_helper drm i2c_core video
CPU: 0 PID: 8625 Comm: umount Not tainted 3.13.0-1.fc21.x86_64 #1
Hardware name: LENOVO 3444FHG/3444FHG, BIOS G6ET96WW (2.56 ) 04/29/2013
 0000000000000009 ffff880040923b70 ffffffff81685ffa ffff880040923bb8
 ffff880040923ba8 ffffffff8106d5ed 0000000000000000 ffffffff81cb0680
 ffff8801e4439838 ffff880040b89188 ffff88020810c100 ffff880040923c08
Call Trace:
 [<ffffffff81685ffa>] dump_stack+0x45/0x56
 [<ffffffff8106d5ed>] warn_slowpath_common+0x7d/0xa0
 [<ffffffff8106d65c>] warn_slowpath_fmt+0x4c/0x50
 [<ffffffff812308ae>] ? sysfs_get_dirent_ns+0x4e/0x70
 [<ffffffff81231b76>] sysfs_remove_group+0xc6/0xd0
 [<ffffffff8141d7a3>] dpm_sysfs_remove+0x43/0x50
 [<ffffffff814134f5>] device_del+0x45/0x1c0
 [<ffffffff8143e767>] scsi_target_reap_usercontext+0x27/0x40
 [<ffffffff81086437>] execute_in_process_context+0x67/0x70
 [<ffffffff8143fbe4>] scsi_target_reap+0xc4/0xf0
 [<ffffffff81441bb6>] scsi_device_dev_release_usercontext+0xe6/0x120
 [<ffffffff81086437>] execute_in_process_context+0x67/0x70
 [<ffffffff81441acc>] scsi_device_dev_release+0x1c/0x20
 [<ffffffff81412b42>] device_release+0x32/0xa0
 [<ffffffff81315f87>] kobject_cleanup+0x77/0x1b0
 [<ffffffff81315e35>] kobject_put+0x35/0x70
 [<ffffffff81412e37>] put_device+0x17/0x20
 [<ffffffff814342cb>] scsi_device_put+0x3b/0x50
 [<ffffffff81446760>] scsi_disk_put+0x30/0x50
 [<ffffffff81446a92>] sd_release+0x42/0xd0
 [<ffffffff811f12ec>] __blkdev_put+0x16c/0x1a0
 [<ffffffff811f128e>] __blkdev_put+0x10e/0x1a0
 [<ffffffff811f1c2c>] blkdev_put+0x4c/0x120
 [<ffffffff811badb4>] kill_block_super+0x44/0x70
 [<ffffffff811bb07d>] deactivate_locked_super+0x3d/0x60
 [<ffffffff811bb626>] deactivate_super+0x46/0x60
 [<ffffffff811d72fc>] mntput_no_expire+0xac/0x140
 [<ffffffff811d876e>] SyS_umount+0x8e/0x100
 [<ffffffff81694fe9>] system_call_fastpath+0x16/0x1b

Comment 1 Igor Raits 2014-01-26 12:42:03 UTC

Created attachment 123371 [details]
dmesg

Comment 2 Igor Raits 2014-01-26 12:42:30 UTC

Created attachment 123381 [details]
another warning

Comment 3 Joe Lawrence 2014-01-27 15:19:59 UTC

Hi Igor,

Does James' latest "target refcounting infrastructure fixes for usb" [1] patchset take care of this for you?

[1] http://www.spinics.net/lists/linux-scsi/msg71631.html

Comment 4 Igor Raits 2014-02-22 14:00:41 UTC

I can't reproduce this bug on master branch, so close it as FIXED.

Comment 5 Igor Raits 2014-03-19 13:02:38 UTC

We can again reproduce this problem.

From RHBZ.

Comment 6 Alan Stern 2014-05-12 15:42:12 UTC

This problem has been fixed by commit e63ed0d7a980 ([SCSI] fix our current target reap infrastructure), which is part of 3.15-rc1.  It will not be ported to earlier stable kernels until James Bottomley is satisfied that it does not introduce any new bugs.  That is why you still see reports of this problem on the distribution Bugzillas from users running 3.13.y and 3.14.y.

The bug report should be closed.