Bug 67151
| Summary: | sky2 module causes kernel BUG in /usr/include/linux/netdevice.h:501 | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | ebrahim.azarisooreh |
| Component: | Network | Assignee: | drivers_network (drivers_network) |
| Status: | RESOLVED CODE_FIX | ||
| Severity: | blocking | CC: | ebrahim.azarisooreh, stf_xl |
| Priority: | P1 | ||
| Hardware: | IA-32 | ||
| OS: | Linux | ||
| Kernel Version: | 3.12.8 | Subsystem: | |
| Regression: | No | Bisected commit-id: | |
| Attachments: | sky2_napi_init.patch | ||
|
Description
ebrahim.azarisooreh
2013-12-17 02:51:55 UTC
Created attachment 123201 [details]
sky2_napi_init.patch
Does the attached patch fix the problem ?
(In reply to Stanislaw Gruszka from comment #1) > Created attachment 123201 [details] > sky2_napi_init.patch > > Does the attached patch fix the problem ? (In reply to Stanislaw Gruszka from comment #1) > Created attachment 123201 [details] > sky2_napi_init.patch > > Does the attached patch fix the problem ? Stanislaw, thank you for your response. I have applied your patch to sky2.c with the kernel 3.12.8 (There was no difference between that one and 3.12.5), and was able to successfully compile the module, however the sky2 does not load succesfully on boot-up. I am working on the issue at the moment, and when I find time I will try to isolate what is going on, and apprise you of the results afterwards. Perhaps patch cause that not-load issue (but AFICT it should not) ? What happen if you reload module manually by "modprobe -r sky2 ; modprobe sky2" ? Stanislaw, silly me I realized that I was only loading the module via modprobe, but not loading the entire compiled kernel... AFAIK you can only do that if you enable DKMS. So my "unsuccessful" modprobe is not a valid result (it was saying bad exec format). I will try again. Thank you for following up. (In reply to Stanislaw Gruszka from comment #4) > Perhaps patch cause that not-load issue (but AFICT it should not) ? What > happen if you reload module manually by "modprobe -r sky2 ; modprobe sky2" ? Actually dkms should not matter here, because I am loading sky2 via modprobe. So recompiling the kernel is not necessary .... My error says: ERROR: could not insert 'sky2': Exec format error Any idea? You compile external sky2 module with wrong kernel sources. You should set proper kernel directory in the Makefile, for example:
KDIR := /lib/modules/$(shell uname -r)/build
obj-m := sky2.o
all:
$(MAKE) -C $(KDIR) M=$(PWD)
Or perhaps you compile for wrong architecture i.e. for 32-bit instead of 64 bit, then you have to specify ARCH= parameter, for example:
$(MAKE) ARCH=x86_64 -C $(KDIR) M=$(PWD)
(In reply to Stanislaw Gruszka from comment #8) > Or perhaps you compile for wrong architecture i.e. for 32-bit instead of 64 > bit, then you have to specify ARCH= parameter, for example: > > $(MAKE) ARCH=x86_64 -C $(KDIR) M=$(PWD) It works! All success! Network is up, and no crash on bootup; earlier I was stripping the debug symbols, I guess linux does not like that? Anyway, thank you for your help and patience, and being a nice guy through it all. One more thing: Who should I notify of this bug? I'll post the patch, it will be queued and applied, but it can take some time before patch will be released with new kernel version. Okay, sound good to me. By the way, try linux-ck kernel if you haven't already, it is awesome. [= And one last expression of my gratitude again; I am in your debt. |