Bug 67091

Summary:	scsi/be2iscsi/be_main.c:328: possible bad if expression ?
Product:	SCSI Drivers	Reporter:	David Binderman (dcb314)
Component:	Other	Assignee:	scsi_drivers-other
Status:	NEW ---
Severity:	normal	CC:	alan
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	3.13-rc4	Subsystem:
Regression:	No	Bisected commit-id:

Description David Binderman 2013-12-16 09:51:01 UTC

Source code is

        if (abrt_task->sc->device->lun != abrt_task->sc->device->lun)
            continue;

Suggest code rework. Bug found by static analyser cppcheck.

[linux-3.13-rc4/drivers/scsi/be2iscsi/be_main.c:328]: (style) Same expression on both sides of '!='.