Bug 6538

Summary:	memory.c:(.text+0x4cb21): undefined reference to `remove_memory'
Product:	Drivers	Reporter:	Toralf Förster (toralf.foerster)
Component:	Other	Assignee:	drivers_other
Status:	CLOSED CODE_FIX
Severity:	low	CC:	nacc
Priority:	P2
Hardware:	i386
OS:	Linux
Kernel Version:	2.6.17-rc4	Subsystem:
Regression:	---	Bisected commit-id:
Attachments:	kernel config make log fix hotplug build beter fix, maybe?

Description Toralf Förster 2006-05-12 12:09:59 UTC

Playing with different kernel configs I got:
...
  UPD     include/linux/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1
drivers/built-in.o: In function `memory_block_action':
memory.c:(.text+0x4cb21): undefined reference to `remove_memory'
make: *** [.tmp_vmlinux1] Error 1

Comment 1 Toralf Förster 2006-05-12 12:10:25 UTC

Created attachment 8098 [details]
kernel config

Comment 2 Toralf Förster 2006-05-12 12:10:42 UTC

Created attachment 8099 [details]
make log

Comment 3 Nishanth Aravamudan 2006-05-12 13:45:02 UTC

Created attachment 8102 [details]
fix hotplug build

Does the attached patch fix it for you?

Thanks,
Nish

Comment 4 Nishanth Aravamudan 2006-05-12 13:49:49 UTC

Created attachment 8105 [details]
beter fix, maybe?

There is a typo in the file, it's CONFIG_MEMORY_HOTPLUG, not
CONFIG_HOTPLUG_MEMORY, see if this fixes it, please?

Comment 5 Toralf Förster 2006-05-12 23:51:23 UTC

right, with the better fix it compiles fine :-)

Comment 6 Nishanth Aravamudan 2006-05-13 08:48:48 UTC

Great, thanks for the test, I have submitted the patch to mainline.

Thanks,
Nish