Bug 64231

Summary:	R8712U floods logs
Product:	Drivers	Reporter:	Alexandre Demers (alexandre.f.demers)
Component:	Staging	Assignee:	drivers_staging (drivers_staging)
Status:	RESOLVED CODE_FIX
Severity:	low	CC:	alan, linville
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	3.12-rc7	Subsystem:
Regression:	No	Bisected commit-id:
Attachments:	Patch to silence r8712u and add a verbose option if wanted

Description Alexandre Demers 2013-11-02 15:25:06 UTC

Would it be possible to silence or add a build variable to unable/disable some log messages from r8712u? I've been using the driver for quite some time and there is only a couple of bugs related to it. It works well and it's stable.

However, I get plenty of the following in my logs:
[ 3145.237706] r8712u 1-1:1.0 wlan0: r8712_got_addbareq_event_callback: mac = 96:0c:6d:f1:2e:b2, seq = 13184, tid = 0
[ 3166.746165] r8712u 1-1:1.0 wlan0: r8712_got_addbareq_event_callback: mac = 96:0c:6d:f1:2e:b2, seq = 17344, tid = 0
[ 3214.841270] r8712u 1-1:1.0 wlan0: r8712_got_addbareq_event_callback: mac = 96:0c:6d:f1:2e:b2, seq = 34960, tid = 0
[ 3228.618211] r8712u 1-1:1.0 wlan0: r8712_got_addbareq_event_callback: mac = 96:0c:6d:f1:2e:b2, seq = 35376, tid = 0
[ 3235.064626] r8712u 1-1:1.0 wlan0: r8712_got_addbareq_event_callback: mac = 96:0c:6d:f1:2e:b2, seq = 35408, tid = 0
[ 3273.671490] r8712u 1-1:1.0 wlan0: r8712_got_addbareq_event_callback: mac = 96:0c:6d:f1:2e:b2, seq = 40528, tid = 0
[ 3281.151590] r8712u 1-1:1.0 wlan0: r8712_got_addbareq_event_callback: mac = 96:0c:6d:f1:2e:b2, seq = 40560, tid = 0

They are pretty much useless and should be reported since they are not exposing any problem.

Comment 1 Alexandre Demers 2013-11-05 01:10:56 UTC

Created attachment 113391 [details]
Patch to silence r8712u and add a verbose option if wanted

It silences the slow flood that was happening by adding a verbose option under Kconfig.

Comment 2 Alan 2013-11-12 15:50:27 UTC

We don't accept patches via bugzilla as we need the email address audit trail and Signed-off-by: lines

Please see Documentation/SubmittingPatches and follow that. If you aren't sure where to send it complete with sign off then greg@kroah.com would be a good guess.

Comment 3 Alexandre Demers 2013-11-12 18:44:33 UTC

That's find, I had figured it out. But thank you for the info Alan. I sent the patch to Larry Finger less than a week ago, but I've just realized that I forgot to add linux-kernel@vger.kernel.org. I'm submitting a slightly modified version.

Comment 4 Alexandre Demers 2014-04-18 02:47:55 UTC

Submitted patch included, commit a7627714452df0cb7171652573c73e3613b24e6a