Bug 6354

Summary: NULL Pointer lapbether
Product: Networking Reporter: Pascal SCLAFER (pascal.sclafer)
Component: OtherAssignee: Arnaldo Carvalho de Melo (acme)
Status: CLOSED CODE_FIX    
Severity: normal    
Priority: P2    
Hardware: i386   
OS: Linux   
Kernel Version: 2.6.14 2.6.15 2.6.16 Subsystem:
Regression: --- Bisected commit-id:

Description Pascal SCLAFER 2006-04-08 08:11:14 UTC 
Problem Description:

Lapbether generate an oops, when I try to receive or sends packets over X25.

I think that the problem was introduced by this patch:
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=86e65da9c1fc6fb421b9f796b597b3eced6b55ab

The line skb->input_dev = skb->dev = dev; was removed from x25devices.h causing
all drivers using x25_type_trans() to crash, because skb->dev stay unintialized.

I think this line should have been replaced by skb->dev=dev;


PS: Sorry for my bad english