Bug 61291

Summary: [BISECTED] - Recent commits against skge.c render ethernet broken
Product: Drivers Reporter: da_audiophile
Component: NetworkAssignee: drivers_network (drivers_network)
Status: CLOSED CODE_FIX    
Severity: high CC: alan, da_audiophile, igor.raits, romieu, yellowhat46
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 3.11.1 Subsystem:
Regression: Yes Bisected commit-id:
Attachments: revert of last three commits
dmesg under error condition

Description da_audiophile 2013-09-14 16:35:05 UTC
Linux kernel v3.11.1 gives me a partially functional network on hardware using the skge driver.  I am running Arch Linux i686.  I do not see anything obvious in the dmesg output to indicate that a problem exists.  I am happy to supply any additional info to help you further diagnose this issue.

Attachments:
*proposed patch to fix problem

Bug fix: Reverting the last 3 commits against drivers/net/ethernet/marvell/skge.c which is contained in the attached patch fixes the issue.  I do not know which of the 3 caused the problem; I am not a programmer/developer.

More info: in the bug state (i.e. using the unmodified 3.11.1 source):

What works:
*Netctl successfully bring up the interface
*I can ping internal IP addresses
*I can resolve domain names; wget can start a download from the AUR (aur.archlinux.org gets resolved to a numerical IP but the download never starts).

What doesn't work:
*I cannot ping external addresses (names or numerical)
*I cannot ssh out or into the box
*I cannot receive data via wget which just hangs indefinitely.

dmesg | grep skge
[    6.020443] skge: 1.14 addr 0xd5000000 irq 17 chip Yukon-Lite rev 7
[    6.020977] skge 0000:01:04.0 eth0: addr 00:0e:a6:70:b8:12
[    9.009004] skge 0000:01:04.0 enp1s4: enabling interface
[   11.906824] skge 0000:01:04.0 enp1s4: Link is up at 1000 Mbps, full duplex, flow control both
[   12.093470] skge 0000:01:04.0 enp1s4: disabling interface
[   12.095851] skge 0000:01:04.0 enp1s4: enabling interface
[   15.733743] skge 0000:01:04.0 enp1s4: Link is up at 1000 Mbps, full duplex, flow control both
Comment 1 da_audiophile 2013-09-14 16:35:36 UTC
Created attachment 108351 [details]
revert of last three commits
Comment 2 da_audiophile 2013-09-14 16:36:27 UTC
Created attachment 108361 [details]
dmesg under error condition
Comment 3 Vasco Gervasi 2013-09-14 21:29:05 UTC
Thanks for the patch.
Comment 4 Francois Romieu 2013-11-15 00:26:02 UTC
(In reply to da_audiophile from comment #0)
> Linux kernel v3.11.1 gives me a partially functional network on hardware
> using the skge driver.  I am running Arch Linux i686.  I do not see anything
> obvious in the dmesg output to indicate that a problem exists.  I am happy
> to supply any additional info to help you further diagnose this issue.
> 
> Attachments:
> *proposed patch to fix problem
> 
> Bug fix: Reverting the last 3 commits against
> drivers/net/ethernet/marvell/skge.c which is contained in the attached patch
> fixes the issue.  I do not know which of the 3 caused the problem; I am not
> a programmer/developer.

It should be fixed now.

Please try a post 3361dc9538832a2a9150a8c722374ca844bf8dc8 kernel (3.12-rc2
or better).

Thanks.

-- 
Ueimor
Comment 5 da_audiophile 2013-11-15 18:50:25 UTC
This issue has been resolved since 3.11.3 or .4 from my memory.  Safe to close.
Comment 6 Alan 2013-11-15 18:56:57 UTC
thanks