Bug 60697
Summary: | Bluetooth re-enabled after resume from hibernation (Lenovo ThinkPad, X201 3626) | ||
---|---|---|---|
Product: | Drivers | Reporter: | Jeffery To (jeffery.to) |
Component: | Platform_x86 | Assignee: | Matthew Garrett (mjg59-kernel) |
Status: | REOPENED --- | ||
Severity: | normal | CC: | chris, hmh, lenb, mjg59-kernel, mledin89, rjw, rjw, sangshuduo, tianyu.lan, wouter.depypere |
Priority: | P1 | ||
Hardware: | x86-64 | ||
OS: | Linux | ||
Kernel Version: | v3.11-rc3 | Subsystem: | |
Regression: | Yes | Bisected commit-id: | |
Attachments: |
Environment info
Output of acpidump Output of dmidecode --dump output of dmidecode --dump environment the output of acpidump Disable win8 mode for ThinkPad X201 and Latitue E6230 new output dmidecode --dump Output of dmidecode, with patch thinkpad_acpi test patch |
Description
Jeffery To
2013-08-05 18:10:19 UTC
Created attachment 107103 [details]
Output of acpidump
Does it help if you append acpi_osi="!Windows 2012" to the kernel's command line? When I add acpi_osi="!Windows 2012" to v3.11-rc4 (which still has this issue), the issue is not present, i.e. Bluetooth stays disabled after resuming. Please attach the output of dmidecode from the affected machine. Created attachment 107133 [details]
Output of dmidecode --dump
Please let me know if you need a binary dump as well.
I've checked the ASL code firmware has provided, it's not clear to me why win8 mode would affect this functionality. But perhaps thinkpad-acpi maintainer Henrique knows the reason. ASL is not the only thing generally affected by OSI. It simply changes the BIOS' behavior and there's no telling which way. Can you reproduce this issue when the thinkpad-acpi driver is not present? I'm able to reproduce this issue without the thinkpad_acpi module loaded (tested with v3.11-rc5). Created attachment 107261 [details]
output of dmidecode --dump
Created attachment 107262 [details]
environment
I also have trouble with this commit, it disables my hardware switch for enable/disable wifi. See [1] for full explanation. When I add acpi_osi="!Windows 2012" it fixes my issue. dmidecode output uploaded as requested [2] and environment [3] [1] http://marc.info/?l=linux-acpi&m=137703324003948&w=2 [2] https://bugzilla.kernel.org/attachment.cgi?id=107261 [3] https://bugzilla.kernel.org/attachment.cgi?id=107262 (In reply to Jeffery To from comment #9) > I'm able to reproduce this issue without the thinkpad_acpi module loaded > (tested with v3.11-rc5). I'm not sure about this, but I remembered bluetooth enable/disable functionality is provided by thinkpad_acpi module. So without that module, can you still disable bluetooth? Or is it that it boots with bluetooth off and when resumed, bluetooth is tured on? (In reply to Wouter Depypere from comment #12) > I also have trouble with this commit, it disables my hardware switch for > enable/disable wifi. See [1] for full explanation. Please also attach acpidump, thanks. (In reply to Aaron Lu from comment #13) > I'm not sure about this, but I remembered bluetooth enable/disable > functionality is provided by thinkpad_acpi module. So without that module, > can you still disable bluetooth? Or is it that it boots with bluetooth off > and when resumed, bluetooth is tured on? With thinkpad_acpi blacklisted, Bluetooth is enabled on boot. I can't turn it off unless I run "modprobe thinkpad_acpi" beforehand. After turning Bluetooth off, I ran "rmmod thinkpad_acpi" before hibernating. I verified that thinkpad_acpi isn't loaded (with lsmod) before hibernating and after resuming. Bluetooth is enabled on resume. I tried this same test with the acpi_osi="!Windows 2012" kernel parameter (and thinkpad_acpi blacklisted). Bluetooth is disabled on boot. I verified that thinkpad_acpi isn't loaded (with lsmod) before hibernating and after resuming. Bluetooth is disabled on resume. (I remember Bluetooth use to be disabled on boot if I left it disabled on shutdown/reboot; this was usually the case since I rarely use Bluetooth. IIRC this changed after upgrading to Raring / the v3.8 kernel; now it is always enabled, and I installed TLP to "fix" this. I didn't file a report for this since I wasn't sure if it was a bug.) (In reply to Rafael J. Wysocki from comment #7) > ASL is not the only thing generally affected by OSI. It simply changes the > BIOS' behavior and there's no telling which way. Then there is nothing we can do I'm afraid... Shall I prepare a patch to do the OSI blacklist for the two systems? Hi Jeffery, Do you have Win8 installed? I wonder what the behavior of Win8 is regarding Bluetooth. (In reply to Aaron Lu from comment #16) > Hi Jeffery, > > Do you have Win8 installed? I wonder what the behavior of Win8 is regarding > Bluetooth. Sorry, I don't have Windows 8. If there's important information to be found, I can find a way to install it. (In reply to Jeffery To from comment #17) > (In reply to Aaron Lu from comment #16) > > Hi Jeffery, > > > > Do you have Win8 installed? I wonder what the behavior of Win8 is regarding > > Bluetooth. > > Sorry, I don't have Windows 8. If there's important information to be found, > I can find a way to install it. Not that important to cost you the license fee, just good to know :-) So forget it, even if we know it works or not, it still doesn't give me any hint why. Created attachment 107280 [details]
the output of acpidump
As requested the output of my acpidump.
Aaron: we have dmidecode above, can you add this to the win8 OSI blacklist? Hi Jeffery and Wouter, Is there any side effects when you use acpi_osi="!Windows 2012"? If not, I'll add your system into the win8 blacklist table. (In reply to Aaron Lu from comment #21) > Hi Jeffery and Wouter, > > Is there any side effects when you use acpi_osi="!Windows 2012"? If not, > I'll add your system into the win8 blacklist table. I added this to my grub config about a month ago and haven't noticed anything particular. (In reply to Jeffery To from comment #22) > (In reply to Aaron Lu from comment #21) > > Hi Jeffery and Wouter, > > > > Is there any side effects when you use acpi_osi="!Windows 2012"? If not, > > I'll add your system into the win8 blacklist table. > > I added this to my grub config about a month ago and haven't noticed > anything particular. It is the same for me. Added it to grub a few months ago and I haven't experienced anything particular. Created attachment 117341 [details]
Disable win8 mode for ThinkPad X201 and Latitue E6230
Please give it a test, no need to specify acpi_osi="!Windows 2012" cmdline option.
Please attach dmidecode again without using the --dump option, that option is for debugging not for human eye :-)
(In reply to Aaron Lu from comment #24) > Created attachment 117341 [details] > Disable win8 mode for ThinkPad X201 and Latitue E6230 > > Please give it a test, no need to specify acpi_osi="!Windows 2012" cmdline > option. > > Please attach dmidecode again without using the --dump option, that option > is for debugging not for human eye :-) I have tested it with 3.13 and the proposed patch and I can confirm it works for me. I will attach the dmidecode shortly. Created attachment 117581 [details]
new output dmidecode --dump
(In reply to Wouter Depypere from comment #25) > (In reply to Aaron Lu from comment #24) > > Created attachment 117341 [details] > > Disable win8 mode for ThinkPad X201 and Latitue E6230 > > > > Please give it a test, no need to specify acpi_osi="!Windows 2012" cmdline > > option. > > > > Please attach dmidecode again without using the --dump option, that option > > is for debugging not for human eye :-) > > I have tested it with 3.13 and the proposed patch and I can confirm it works > for me. I will attach the dmidecode shortly. 3.13 with the patch also works for me - thanks! Created attachment 117721 [details]
Output of dmidecode, with patch
Thanks for the confirm, patch sent out: https://patchwork.kernel.org/patch/3293091/ Created attachment 118041 [details]
thinkpad_acpi test patch
Jeffery,
Can you test this patch without Aaron's patch applied?
Mathew, I tried your patch with 3.13-rc3 (without Aaron's patch or the acpi_osi parameter). Bluetooth was re-enabled after resuming from hibernate. I'm from 2017 and the bug is still here :( acpi_osi="!Windows 2012" workaround works. |