Bug 60652

Summary: arch/x86/kvm/svm.c: svm_vcpu_reset() and uninitialized dummy variable?
Product: Virtualization Reporter: Mikko Rapeli (mikko.rapeli)
Component: kvmAssignee: virtualization_kvm
Status: CLOSED WILL_NOT_FIX    
Severity: normal CC: alan
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 3.11rc2 Subsystem:
Regression: No Bisected commit-id:

Description Mikko Rapeli 2013-07-29 21:22:58 UTC
Coverity CID 751495 feels a bit like a false positive. Is the dummy variable not initialized on purpose?

1196static void svm_vcpu_reset(struct kvm_vcpu *vcpu)
1197{
1198        struct vcpu_svm *svm = to_svm(vcpu);
    	1. var_decl: Declaring variable "dummy" without initializer.
1199        u32 dummy;
1200        u32 eax = 1;
1201
1202        init_vmcb(svm);
1203
    	
CID 751495 (#1 of 1): Uninitialized scalar variable (UNINIT)
2. uninit_use_in_call: Using uninitialized value "dummy" when calling "kvm_cpuid(struct kvm_vcpu *, u32 *, u32 *, u32 *, u32 *)". [hide details]
1204        kvm_cpuid(vcpu, &eax, &dummy, &dummy, &dummy);
/arch/x86/kvm/cpuid.c
646void kvm_cpuid(struct kvm_vcpu *vcpu, u32 *eax, u32 *ebx, u32 *ecx, u32 *edx)
647{
   	1. read_parm: Reading a parameter value.
648        u32 function = *eax, index = *ecx;
649        struct kvm_cpuid_entry2 *best;
650
651        best = kvm_find_cpuid_entry(vcpu, function, index);
652
653        if (!best)
654                best = check_cpuid_limit(vcpu, function, index);
655
Comment 1 Alan 2013-11-13 16:34:55 UTC
Coverity is being paranoid.