Bug 60451
Summary: | Missing NULL check of the return value of dev_alloc_skb() in function fwSendNullPacket() in file drivers/staging/rtl8192u/r819xU_firmware.c | ||
---|---|---|---|
Product: | Drivers | Reporter: | RUC_Soft_Sec (rucsoftsec) |
Component: | Staging | Assignee: | drivers_staging (drivers_staging) |
Status: | RESOLVED CODE_FIX | ||
Severity: | normal | CC: | levex, mrazec |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 3.10 | Subsystem: | |
Regression: | No | Bisected commit-id: | |
Attachments: | PATCH dev_alloc_skb() is checking against NULL value before it is used. |
Description
RUC_Soft_Sec
2013-07-04 06:36:37 UTC
Created attachment 107044 [details] PATCH dev_alloc_skb() is checking against NULL value before it is used. According to the tip RUC_Soft_Sec, I'm creating a patch for verification of this value(skb = dev_alloc_skb()) when it is null and we will launch a warning(pr_warn) if this occurs. Please let me know if you have any questions or concerns. Thanks in advance, Mario 'Razec' Ponciano <mrazec@gmail.com> (In reply to Mario "Razec" Ponciano from comment #1) > Created attachment 107044 [details] > PATCH dev_alloc_skb() is checking against NULL value before it is used. > > According to the tip RUC_Soft_Sec, I'm creating a patch for verification of > this value(skb = dev_alloc_skb()) when it is null and we will launch a > warning(pr_warn) if this occurs. Please let me know if you have any > questions or concerns. > > Thanks in advance, > > Mario 'Razec' Ponciano <mrazec@gmail.com> Hi, can you please post the patch with a proper warning message like this: dev_warn(&dev->dev, "%s: Unable to allocate memory for sk buffer!\n", __func__); To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: Xenia Ragiadakou <burzalodowa@gmail.com> Cc: devel@driverdev.osuosl.org Cc: LKML <linux-kernel@vger.kernel.org> Cc: Levente Kurusa <levex@linux.com> Thanks! Levente Kurusa |