Bug 58471
| Summary: | brcmsmac no longer has conectivity | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | Mike Lothian (mike) |
| Component: | network-wireless | Assignee: | drivers_network-wireless (drivers_network-wireless) |
| Status: | CLOSED CODE_FIX | ||
| Severity: | normal | CC: | alan, aspriel, hauke, linville, mike, parag.lkml |
| Priority: | P1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Kernel Version: | 3.10-rc1 | Subsystem: | |
| Regression: | Yes | Bisected commit-id: | |
| Attachments: |
Broken dmesg
Working dmesg brcmsmac: disable power saving |
||
Created attachment 101911 [details]
Working dmesg
And this is the device: 02:00.0 Network controller [0280]: Broadcom Corporation BCM43224 802.11a/b/g/n [14e4:4353] (rev 01) Still present in rc2 and rc3 is due out soon - has anyone else been able to confirm this? Created attachment 102741 [details]
brcmsmac: disable power saving
Could you please test the following patch. There was also a discussion about this problem on the mailing list: http://permalink.gmane.org/gmane.linux.kernel.wireless.general/108251 Double whammy - I now have connectivity and my dmesg is no longer being spammed :D Are we any closer to getting a solution merged? Still not working with today's mainline build and git log seems to say the patch wasn't merged. What's the hold up with getting the patch merged? Not sure where you are looking, it's in Linus's tree: commit 541e667e1c0f31a7e11d909eb831cf476814a201 Author: Arend van Spriel <arend@broadcom.com> Date: Thu Jun 6 13:29:56 2013 +0200 brcmsmac: disable power-save related functions This patch fixes a regression introduced by: commit 6da3b6c48d79da96a36c2632053cf4f53bf48fb2 Author: Hauke Mehrtens <hauke@hauke-m.de> Date: Sun Mar 24 01:45:52 2013 +0100 brcmsmac: remove brcms_bss_cfg->associated The regression behaviour was described on mailing list. http://mid.gmane.org/5197DC4F.7030503@broadcom.com: "On laptop I installed kernel with brcmsmac compiled as module. It comes up and associates during boot, but after logging in there is no connectivity. Triggering reassoc gives connectivity for some time, but after a while (1-2 min) it stops." Before the mentioned commit the return value of the function brcms_c_ps_allowed() was always false, which is desired behaviour as power-save is not supported at the moment. Therefor, the function is changed to just return false instead of simply reverting the mentioned commit. Bug: 58471 <https://bugzilla.kernel.org/show_bug.cgi?id=58471> Signed-off-by: Arend van Spriel <arend@broadcom.com> Signed-off-by: John W. Linville <linville@tuxdriver.com> I did a git log drivers/net/wireless/brcm80211/brcmsmac/main.c and it didn't show the commit. Turns out my tree wasn't updated for some reason. I didn't bother to look carefully because the Ubuntu daily kernel build from yesterday was also having the same connectivity issue described in this bug - it associates but there is no connectivity and reassoc does briefly will investigate further - may be the Ubuntu folks are also missing the patch or this is a different issue with same symptoms. Thanks. Up until yesterday Ubuntu daily mainline builds didn't work - but today's build does seem to fix the issue - which is strange as the patch that fixed it seemed to have been there since Jun 6. In any case - thank you for the patch and merge - I will finally go back to a fully working 3.10 kernel! |
Created attachment 101901 [details] Broken dmesg Since commit [6da3b6c48d79da96a36c2632053cf4f53bf48fb2] brcmsmac: remove brcms_bss_cfg->associated My wireless no longer has any connectivity - it appears connected but pinging google.com doesn't work and websites no longer connect I've attached my before and after dmesg's and I'll see if I can revert that patch If it makes any difference the brcmsmac used to spam my logs with lots of errors - but it did work