Bug 55771
Summary: | ath9k: Calibration Failure Leads To Inability To Associate | ||
---|---|---|---|
Product: | Drivers | Reporter: | Robert Shade (robert.shade) |
Component: | network-wireless | Assignee: | drivers_network-wireless (drivers_network-wireless) |
Status: | NEW --- | ||
Severity: | normal | CC: | iwtbavbm, linville, mcgrof, sujith |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 3.8.4 | Subsystem: | |
Regression: | No | Bisected commit-id: | |
Attachments: |
Patch to disable fastcc and always cold reset
xmit debug after auth timeout xmit debug after reset Potential Fix |
Description
Robert Shade
2013-03-26 13:14:53 UTC
Created attachment 96211 [details]
Patch to disable fastcc and always cold reset
After discussing with Adrian Chadd, I've been testing with the attached patch to eliminate potential issues with Fast Channel Change and warm resets.
The issue still occurs with this patch.
I should note that removing/replacing the ath9k module fixes the issue Created attachment 96301 [details]
xmit debug after auth timeout
/sys/kernel/debug/ieee80211/phy0/ath9k/xmit after the authentication has timed out, but before the chip is reset to scan
Created attachment 96311 [details]
xmit debug after reset
/sys/kernel/debug/ieee80211/phy0/ath9k/xmit after the authentication has timed
out and after the chip is reset to scan
Think I found it: In ath_reset_internal, before we reset, we call ath_prepare_reset, which calls ath9k_hw_disable_interrupts. If the channel change fails, we never call ath_complete_reset, which calls ath9k_hw_enable_interrupts. ath9k_hw_{enable|disable}_interrupts calls definitely needs to be balanced. Looking at an old log, IER never gets re-enabled after the channel set failure. Every time it tries to enable it, you see "Do not enable IER ref count X" in the log, I've seen this as high as -97 for units that have been on for several weeks. Any suggestions on the proper cleanup? Could we just call ath_complete_reset anyway? Some sort of special handling? Created attachment 96911 [details]
Potential Fix
I've successfully tested this patch. This does not fix the root cause of whatever is causing the calibration to fail, but it does clean up if a failure occurs. I also queue a reset since obviously something went wrong and that's our best effort to fix it.
Well, the patch has been merged, but I am not sure if queueing a reset in case a reset fails is correct. We might end up doing endless resets.... Are you still seeing the calibration failure ? Is PowerSave enabled ? (In reply to comment #7) > Well, the patch has been merged, but I am not sure if queueing a reset in > case > a reset fails is correct. We might end up doing endless resets.... > > Are you still seeing the calibration failure ? Is PowerSave enabled ? Yes, I still see it and have replicated it with both PS on and off. Hi guys, I also meet the same issue. Platform: Atheros QCA4531 OS: Linux 4.4.60 Error Logs: [ 3521.992941] wlan0: authenticate with 00:0f:c9:55:9a:08 [ 3521.998410] wlan0: Allocated STA 00:0f:c9:55:9a:08 [ 3522.010067] wlan0: Inserted STA 00:0f:c9:55:9a:08 [ 3522.010099] wlan0: send auth to 00:0f:c9:55:9a:08 (try 1/3) [ 3522.240495] wlan0: send auth to 00:0f:c9:55:9a:08 (try 2/3) [ 3522.414592] wlan0: send auth to 00:0f:c9:55:9a:08 (try 3/3) [ 3522.634321] wlan0: authentication with 00:0f:c9:55:9a:08 timed out [ 3522.640752] wlan0: Removed STA 00:0f:c9:55:9a:08 [ 3522.641115] wlan0: Destroyed STA 00:0f:c9:55:9a:08 [ 3643.002766] wlan0: authenticate with 00:0f:c9:55:9a:08 [ 3643.008234] wlan0: Allocated STA 00:0f:c9:55:9a:08 [ 3643.019898] wlan0: Inserted STA 00:0f:c9:55:9a:08 [ 3643.019929] wlan0: send auth to 00:0f:c9:55:9a:08 (try 1/3) [ 3643.129988] wlan0: send auth to 00:0f:c9:55:9a:08 (try 2/3) [ 3643.231366] wla366] wla auth to 00:0f:c9:55:9a:08 (try 3/3) [ 3643.337126] wlan0: authentication with 00:0f:c9:55:9a:08 timed out [ 3643.343607] wlan0: Removed STA 00:0f:c9:55:9a:08 [ 3643.343974] wlan0: Destroyed STA 00:0f:c9:55:9a:08 [ 3764.714292] wlan0: authenticate with 00:0f:c9:55:9a:08 [ 3764.719688] wlan0: Allocated STA 00:0f:c9:55:9a:08 [ 3764.731425] wlan0: Inserted STA 00:0f:c9:55:9a:08 [ 3764.731457] wlan0: send auth to 00:0f:c9:55:9a:08 (try 1/3) [ 3764.861011] wlan0: send auth to 00:0f:c9:55:9a:08 (try 2/3) [ 3764.962540] wlan0: send auth to 00:0f:c9:55:9a:08 (try 3/3) [ 3765.058784] wlan0: authentication with 00:0f:c9:55:9a:08 timed out [ 3765.065253] wlan0: Removed STA 00:0f:c9:55:9a:08 [ 3765.065610] wlan0: Destroyed STA 00:0f:c9:55:9a:08 I just want to know whether this bug is still there, or solved? Thanks very much. (In reply to Tom Liu from comment #9) > Hi guys, > > I also meet the same issue. > Platform: Atheros QCA4531 > OS: Linux 4.4.60 > Error Logs: > [ 3521.992941] wlan0: authenticate with 00:0f:c9:55:9a:08 > [ 3521.998410] wlan0: Allocated STA 00:0f:c9:55:9a:08 > [ 3522.010067] wlan0: Inserted STA 00:0f:c9:55:9a:08 > [ 3522.010099] wlan0: send auth to 00:0f:c9:55:9a:08 (try 1/3) > [ 3522.240495] wlan0: send auth to 00:0f:c9:55:9a:08 (try 2/3) > [ 3522.414592] wlan0: send auth to 00:0f:c9:55:9a:08 (try 3/3) > [ 3522.634321] wlan0: authentication with 00:0f:c9:55:9a:08 timed out > [ 3522.640752] wlan0: Removed STA 00:0f:c9:55:9a:08 > [ 3522.641115] wlan0: Destroyed STA 00:0f:c9:55:9a:08 > [ 3643.002766] wlan0: authenticate with 00:0f:c9:55:9a:08 > [ 3643.008234] wlan0: Allocated STA 00:0f:c9:55:9a:08 > [ 3643.019898] wlan0: Inserted STA 00:0f:c9:55:9a:08 > [ 3643.019929] wlan0: send auth to 00:0f:c9:55:9a:08 (try 1/3) > [ 3643.129988] wlan0: send auth to 00:0f:c9:55:9a:08 (try 2/3) > [ 3643.231366] wla366] wla auth to 00:0f:c9:55:9a:08 (try 3/3) > [ 3643.337126] wlan0: authentication with 00:0f:c9:55:9a:08 timed out > [ 3643.343607] wlan0: Removed STA 00:0f:c9:55:9a:08 > [ 3643.343974] wlan0: Destroyed STA 00:0f:c9:55:9a:08 > [ 3764.714292] wlan0: authenticate with 00:0f:c9:55:9a:08 > [ 3764.719688] wlan0: Allocated STA 00:0f:c9:55:9a:08 > [ 3764.731425] wlan0: Inserted STA 00:0f:c9:55:9a:08 > [ 3764.731457] wlan0: send auth to 00:0f:c9:55:9a:08 (try 1/3) > [ 3764.861011] wlan0: send auth to 00:0f:c9:55:9a:08 (try 2/3) > [ 3764.962540] wlan0: send auth to 00:0f:c9:55:9a:08 (try 3/3) > [ 3765.058784] wlan0: authentication with 00:0f:c9:55:9a:08 timed out > [ 3765.065253] wlan0: Removed STA 00:0f:c9:55:9a:08 > [ 3765.065610] wlan0: Destroyed STA 00:0f:c9:55:9a:08 > > I just want to know whether this bug is still there, or solved? Thanks very > much. Sorry, I lost this: Network Controller is AR9531, thanks. |