Bug 55001

Summary: [PATCH] suspend/resume doesn't work, results in reboot
Product: ACPI Reporter: Fabio Valentini (decathorpe)
Component: Power-Sleep-WakeAssignee: Aaron Lu (aaron.lu)
Status: CLOSED CODE_FIX    
Severity: normal CC: aaron.lu, rjw
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 2.6.35 and newer Subsystem:
Regression: Yes Bisected commit-id:
Attachments: patch to add machine to the blacklist
dmidecode output

Description Fabio Valentini 2013-03-09 16:26:51 UTC 
Created attachment 94991 [details]
patch to add machine to the blacklist

How to reproduce on Sony Vaio VGN-FW21M:
- make the laptop suspend
- press any key
- laptop reboots (instead of resuming).

Adding acpi_sleep=nonvs to the boot command line fixes the problem, computer resumes just fine.
As this is a regression (it used to work some years ago and the bug was introduced with 2.6.35, as far as I can tell), I think it would be good if a fix  also found it's way down to stable kernel releases.

According to the following commits

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=72ad5d77fb981963edae15eee8196c80238f5ed0
and
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=539986482b0db07b7164ab086d167ab99b4d3061

this system just needs to be added to the blacklist in
drivers/acpi/sleep.c
in order for suspend/resume to work out of the box (again).

I attached a patch that adds this system to the blacklist. Suspend/resume works fine with the modified kernel, without the need for the extra boot parameter.
The patch was created against the most recent (at the time of writing) kernel master branch.
Comment 1 Fabio Valentini 2013-03-09 16:27:34 UTC 
Created attachment 95001 [details]
dmidecode output
Comment 2 Aaron Lu 2013-03-11 07:10:49 UTC 
Hi,

Thanks for the patch.

Can you please send the patch to "Rafael J. Wysocki" <rjw@sisk.pl> and cc the linux-acpi@vger.kernel.org mailing list? And please add the following line to your patch change log:
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=55001

Thanks.
Comment 3 Aaron Lu 2013-03-18 06:55:08 UTC 
Patch sent: https://patchwork.kernel.org/patch/2250121/, no comments yet.
Comment 4 Aaron Lu 2013-03-27 04:38:39 UTC 
Merged by Rafael into linux-pm.git/linux-next as 469dd1c4ac0869cf7d1f87eac9b5a93865c10b76.
Comment 5 Aaron Lu 2013-04-07 06:29:00 UTC 
The following commit merged by Linus from v3.0-rc5.

commit 469dd1c4ac0869cf7d1f87eac9b5a93865c10b76
Author: Fabio Valentini <fafatheone@gmail.com>
Date:   Mon Mar 11 19:16:34 2013 +0000

    ACPI / PM: fix suspend and resume on Sony Vaio VGN-FW21M
Comment 6 Aaron Lu 2013-04-07 06:29:35 UTC 
(In reply to comment #5)
> The following commit merged by Linus from v3.0-rc5.

Should be v3.9-rc5

> 
> commit 469dd1c4ac0869cf7d1f87eac9b5a93865c10b76
> Author: Fabio Valentini <fafatheone@gmail.com>
> Date:   Mon Mar 11 19:16:34 2013 +0000
> 
>     ACPI / PM: fix suspend and resume on Sony Vaio VGN-FW21M