Bug 4947

Summary:	Thinkpad ACPI needs update
Product:	Drivers	Reporter:	Johannes Hansen (osos)
Component:	Platform	Assignee:	Borislav Deianov (borislav)
Status:	CLOSED CODE_FIX
Severity:	normal	CC:	acpi-bugzilla
Priority:	P2
Hardware:	i386
OS:	Linux
Kernel Version:	2.6.13	Subsystem:
Regression:	---	Bisected commit-id:
Attachments:	ibm-acpi.tar.gz c-file to be copied to the acpi sourcetree. v0.11 ibm-acpi-0.12 (patch for 2.6.13-rc6+acpi-20050729) drivers/acpi/ibm_acpi.c Documentation/ibm-acpi.txt

Description Johannes Hansen 2005-07-27 01:45:35 UTC

Current IBM-ACPI in kernel is version 0.8.
http://ibm-acpi.sf.net has a stable version 0.11

Version 0.8 lacks support for importent hardware sensors, fan control
docking/undocking. Much is fixed in version 0.11.

Please upgrade!

Comment 1 Len Brown 2005-08-15 14:01:19 UTC

Boris,
Please attach the version of the driver you'd like me to include
with 2.6.14, and I'll start by including it with the 2.6.13 ACPI patch.
Please run it through Lindent before releasing it.

thanks,
-Len

Comment 2 Johannes Hansen 2005-08-15 22:21:26 UTC

Created attachment 5648 [details]
ibm-acpi.tar.gz

Comment 3 Johannes Hansen 2005-08-15 22:26:03 UTC

Created attachment 5649 [details]
c-file to be copied to the acpi sourcetree. v0.11

I created attachment of the newest ibm-acpi version. Both the tar.gz and the
c-file.

The file only needs to overwrite the old one, no new configuration options
needed.
Documentation needs update too, can be found in tar.gz as README.

Thank you for adding this.

Comment 4 Borislav Deianov 2005-08-16 10:19:49 UTC

The current version (0.11) is not suitable for inclusion as it needs some
compilation fixes and reformatting. I'm working on an update.

Comment 5 Borislav Deianov 2005-08-16 23:21:23 UTC

Created attachment 5654 [details]
ibm-acpi-0.12 (patch for 2.6.13-rc6+acpi-20050729)

Len,

Please apply the attached patch (ibm-acpi-0.12). It brings the driver up
to the latest version and includes the changes already in the tree. It's
been run through Lindent. The new features in this version have had
extensive testing (~4500 downloads).

Thanks,
Boris

Comment 6 Len Brown 2005-08-25 14:10:21 UTC

gah, it didn't apply and I don't see the 
full 0.12 version on the site. 
 
is 0.12 the same as 0.11 but Lindented? 
If yes, I can get 0.11 from your site, 
over-write the Lindented version in Linux, 
and then Lindent the result.

Comment 7 Borislav Deianov 2005-08-25 14:18:37 UTC

Created attachment 5763 [details]
drivers/acpi/ibm_acpi.c

Comment 8 Borislav Deianov 2005-08-25 14:22:52 UTC

Created attachment 5764 [details]
Documentation/ibm-acpi.txt

Len, 

Please replace Documentation/ibm-acpi.txt and drivers/acpi/ibm_acpi.c with the
files from the last two attachments. Those are exactly the same as in the patch

(0.12, Lindented and incorporating previous changes in the tree.)

Regards,
Boris

Comment 9 Len Brown 2005-09-02 23:18:39 UTC

applied

Comment 10 Len Brown 2005-09-09 09:16:11 UTC

Shipped in 2.6.13-git9.
Closing.