Bug 46081

Summary:	[TRIVIAL]vme/bridges/vme_ca91cx42.c:1382: Bad if test
Product:	Drivers	Reporter:	David Binderman (dcb314)
Component:	Other	Assignee:	drivers_other
Status:	NEW ---
Severity:	normal	CC:	alan
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	3.5-rc6	Subsystem:
Regression:	No	Bisected commit-id:

Description David Binderman 2012-08-17 09:17:35 UTC

I just ran the static analyser cppcheck over the source code of the
linux kernel version 3.6-rc2.

It said

[linux-3.6-rc2/drivers/vme/bridges/vme_ca91cx42.c:1382]: (style) Expression '(X & 0x50000) == 0x20000' is always false

The source code is

    if ((lm_ctl & CA91CX42_LM_CTL_AS_M) == CA91CX42_LM_CTL_AS_A32)
        *aspace = VME_A32;

but

#define CA91CX42_LM_CTL_AS_M        (5<<16)
#define CA91CX42_LM_CTL_AS_A16      0
#define CA91CX42_LM_CTL_AS_A24      (1<<16)
#define CA91CX42_LM_CTL_AS_A32      (1<<17)

Wild stab in the dark, but the first macro definition looks wrong.
Maybe

#define CA91CX42_LM_CTL_AS_M        (3<<16)

would be better.