Bug 4403
Summary: | atomic counter underflow in smbfs | ||
---|---|---|---|
Product: | Alternate Trees | Reporter: | Jean Delvare (jdelvare) |
Component: | mm | Assignee: | Adrian Bunk (bunk) |
Status: | CLOSED CODE_FIX | ||
Severity: | high | CC: | bunk |
Priority: | P2 | ||
Hardware: | i386 | ||
OS: | Linux | ||
Kernel Version: | 2.6.12-rc1-mm3 | Subsystem: | |
Regression: | --- | Bisected commit-id: | |
Attachments: | Proposed replacement patch |
Description
Jean Delvare
2005-03-25 23:38:41 UTC
I can reproduce it on a different client machine (completely different hardware, Slackware 10.1, samba 3.0.10) running 2.6.12-rc1-mm3 as well. Same server though. Reverting fs-smbfs-requestc-fix-null-dereference.patch fixed the problem, and actually the patch looks broken to me. Created attachment 4804 [details]
Proposed replacement patch
Thanks for this report. I'll discuss it in your linux-kernel message. The faulty patch was dropped in 2.6.12-rc1-mm4, fixing the problem. This bug seems to have reappeared in 2.6.16-rc4-mm1. Looking at the code for request.c it seems as if Jean's patch hasn't been applied yet. smb_add_request: request [cc805080, mid=52] timed out! BUG: atomic counter underflow at: <df9afac0> smb_rput+0x1b/0x6b [smbfs] <df9abdb6> smb_proc_readX+0xd3/0xdb [smbfs] <df9af0a7> smb_readpage+0xd5/0x15a [smbfs] <c01379ed> __do_page_cache_readahead+0x1db/0x244 <c02e989e> release_sock+0x6e/0xbf <c02e98e7> release_sock+0xb7/0xbf <c0118a10> local_bh_enable+0x5f/0x73 <c030db02> tcp_sendmsg+0x898/0x94e <c0137c55> blockable_page_cache_readahead+0x45/0x99 <c0137dd2> page_cache_readahead+0x9c/0x132 <c0132ef0> do_generic_mapping_read+0x155/0x441 <c013391d> __generic_file_aio_read+0x16d/0x1b8 <c0131cfa> file_read_actor+0x0/0xe2 <c0133ac6> generic_file_read+0xad/0xc3 <c01249b4> autoremove_wake_function+0x0/0x3a <df9ae9c1> smb_revalidate_inode+0x50/0x58 [smbfs] <df9aed42> smb_file_read+0x26/0x72 [smbfs] <c014b691> vfs_read+0x87/0x11d <c014bfbd> sys_read+0x3b/0x64 <c0102b93> sysenter_past_esp+0x54/0x75 smb_add_request: request [cc805e80, mid=53] timed out! John, what makes you think the original bug and yours are the same? Granted, the trace looks the same, but there are no changes to fs/smbfs/request.c in 2.6.16-rc4-mm1 so the cause of the problem is unlikely to be the same. Note that there is nothing wrong with my patch not having been applied. It was simply a proposed replacement for the -mm patch which had been causing the problem in the first place; that original patch was finally discarded. I hope to have some time to test 2.6.16-rc4-mm1 myself this evening and see if I can reproduce your problem. At any rate, I believe you'd better open a new bug. Any news about this? I wasn't able to reproduce the problem, smbfs seems to work fine for me in 2.6.16-rc4-mm1 and -mm2. John, can you please try 2.6.16-rc5-mm2 and report? No feedback from John Carter, so I am closing this bug again. |